From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 35DA23858C2F for ; Wed, 13 Dec 2023 13:18:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35DA23858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 35DA23858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702473528; cv=none; b=njxgFoOwfQnYT+G4vX+cTkErCU4Mc0EQV+UVqg3cPKgrJxG1+cCl+XomaBBPJbuGfm7lU1sVgcwEzejAHYCxVKO/aEwg6rUeg+W1CBs3jOuafg76qEDbjAOCF8xEQmWV6g4DO2xcsk5IlRpDf4gcUFnToe8ShSTm+3oqXcevNx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702473528; c=relaxed/simple; bh=HYleDhXDFIO4TikKMndTiOsAeG0yqn2G3/MTSWiq4N4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=s9D1ry1feyLvUZOTQ2HBckrgJWaowqJ78SwzRFHzW6pftsbfbNbm/f1wobscIR65Y9j94eQC77idwhenVEXYlT+d1e91jHAo/9UIwNmQ8A5QFbbQ2ih1gMhkukZQcHCRBqLNxaewAxCPNdyYne165+VFYVHnXC9Z9Y1F9EXI/1k= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702473525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mo7M3ldO86Ulr/J7mpnEsd0WRsdM4f/wfi38Kmf4Xsc=; b=dmd3eB2/kpeMt/SHw796aeok3KYqFchSVcet1hxfaBFIhAL/h0PaLuTXUmDFmnbPjTYynk TAD/ZRYrqkxmjSBOyJJQo8X70Te0lOQJje+jwpLzWX6PfDO+xG+qy0HLts0XnK1yJnBEY5 nDLPGsgHjhe8YReNEJwyEkFBveR5ycg= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-8KWs0xj6Pw6wUB04s39yRg-1; Wed, 13 Dec 2023 08:18:44 -0500 X-MC-Unique: 8KWs0xj6Pw6wUB04s39yRg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-50bea1c4468so6202575e87.3 for ; Wed, 13 Dec 2023 05:18:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702473523; x=1703078323; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mo7M3ldO86Ulr/J7mpnEsd0WRsdM4f/wfi38Kmf4Xsc=; b=lVDeQZ9skczsQvHw0atsF707MYlq3mZEteCXXGxaim/KhJPPxmj4wuGQWW7HlZA2LB gjOuVl4ir5ZDnTo5QQUOtS8I4FZ1e/Rye4TbR9tdg/tqo2HrN8YGdS5xW593Cett20n0 KCPS2hD+RfjmPSujmUtfLzuoyqnbgJi3NYbb2ijX70IzqnCF47WT++nyQNWQkDN7Xeyr UYOMatFsjN+bSNzWJjH8ZpMXqz7bGBryReLqhr0lfuxDai75nvG9SCodmuBYbuH/UM/G iJmJn77KcnW1xpRT/eqNCPq+dQelf3iiUEAhrgLwRv3m/jHdCcX8zoIUHs4wVabnPR8B qD+A== X-Gm-Message-State: AOJu0YyUelJQseJGb6XGUsj8eUPANew1JSwG6YSt0OIfTtglzEzCUvIJ e7cYjU2Ou8XP8WIkNlZ8hgBBD2vmwsjAAAzssKHsQ17vNQymjRYp2UljDYxbNE1eOMJipz/2qft O0NksYvr7b2d+6VvUl98iDgNhM5qXqb2+82Q9czH9ag6ftY2Js+T7UlZCnt/nwMrXhTqp9VOh7h 5nLH4D X-Received: by 2002:a05:6512:3c9f:b0:50b:e20b:93eb with SMTP id h31-20020a0565123c9f00b0050be20b93ebmr5536279lfv.60.1702473523142; Wed, 13 Dec 2023 05:18:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGw2HAovNDqxWCTfbH7p2ut+agcUX/keZ/MCIhMxGD8SP7Sogak7pzPb8ZtWLjHRKJLg6EpHA== X-Received: by 2002:a05:6512:3c9f:b0:50b:e20b:93eb with SMTP id h31-20020a0565123c9f00b0050be20b93ebmr5536266lfv.60.1702473522685; Wed, 13 Dec 2023 05:18:42 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id re14-20020a170907a2ce00b00a1f751d2ba4sm7091202ejc.99.2023.12.13.05.18.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 05:18:42 -0800 (PST) Message-ID: Date: Wed, 13 Dec 2023 14:18:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] gdb/testsuite: Test for a backtrace through object without debuginfo From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen References: <20231213131606.676035-1-blarsen@redhat.com> In-Reply-To: <20231213131606.676035-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 13/12/2023 14:16, Guinevere Larsen wrote: > From: Fedora GDB patches Oops, I didn't realize I forgot to change the author of the commit. I'll update this locally. -- Cheers, Guinevere Larsen She/Her/Hers > > Fedora has been carrying this test since back in the Project Archer > days. A change back then caused GDB to stop being able to backtrace when > only some of the object files had debug information. Even though the > changed code never seems to have made its way into the main GDB project, > I think it makes sense to bring the test along to ensure something like > this doesn't pass unnoticed. > --- > .../backtrace-through-cu-nodebug-caller.c | 28 ++++++ > .../backtrace-through-cu-nodebug-main.c | 32 +++++++ > .../gdb.base/backtrace-through-cu-nodebug.exp | 89 +++++++++++++++++++ > 3 files changed, 149 insertions(+) > create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c > create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c > create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c > new file mode 100644 > index 00000000000..a33f86d1ece > --- /dev/null > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c > @@ -0,0 +1,28 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2005-2023 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +typedef int (*callback_t) (void); > + > +int > +caller (callback_t callback) > +{ > + /* Ensure some frame content to push away the return address. */ > + volatile const long one = 1; > + > + /* Modify the return value to prevent any tail-call optimization. */ > + return (*callback) () - one; > +} > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c > new file mode 100644 > index 00000000000..f958c0200c7 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c > @@ -0,0 +1,32 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2005-2023 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +typedef int (*callback_t) (void); > + > +extern int caller (callback_t callback); > + > +int > +callback (void) > +{ > + return 1; > +} > + > +int > +main (void) > +{ > + return caller (callback); > +} > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > new file mode 100644 > index 00000000000..9b5ec3af428 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > @@ -0,0 +1,89 @@ > +# Copyright 2010-2023 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Test that GDB can generate accurate backtraces even if some of the stack > +# trace goes through a function with no debug information. > + > +standard_testfile -caller.c -main.c > +set objmainfile ${testfile}-main.o > +set objcallerfile ${testfile}-caller.o > + > +# recompile the inferior with or without CFI information, then run the > +# inferior until the point where the important test starts > +# returns TRUE on an ERROR. > +proc prepare_test {has_cfi} { > + global srcdir subdir srcfile srcfile2 objmainfile objcallerfile binfile > + if {$has_cfi} { > + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" ${objcallerfile} \ > + object [list {additional_flags=-fomit-frame-pointer \ > + -funwind-tables -fasynchronous-unwind-tables}]] != "" } { > + untested "couldn't compile without cfi" > + return true > + } > + } else { > + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" ${objcallerfile} \ > + object [list {additional_flags=-fomit-frame-pointer \ > + -fno-unwind-tables \ > + -fno-asynchronous-unwind-tables}]] != "" } { > + untested "couldn't compile with cfi" > + return true > + } > + } > + if {[gdb_compile "${objmainfile} ${objcallerfile}" ${binfile} \ > + binfile {}] != ""} { > + untested "couldn't link object files" > + return true > + } > + > + clean_restart $binfile > + > + if ![runto callback] then { > + fail "$has_cfi: Can't run to callback" > + return 0 > + } > + return false > +} > + > +if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" ${objmainfile} \ > + object {debug}] != "" } { > + untested "couldn't compile main file" > + return > +} > + > +if { [prepare_test false] } { > + untested ${testfile}.exp > +} else { > + gdb_test_multiple "bt" "verify unwinding breaks without CFI" { > + -re -wrap " in \[?\]\[?\] .*" { > + # It may backtrace through some random frames even to main(). > + pass $gdb_test_name > + } > + -re -wrap " in main .*" { > + fail $gdb_test_name > + } > + } > +} > + > +if { [prepare_test true] } { > + untested ${testfile}.exp > +} else { > + > + # #0 callback () at ... > + # #1 0x00000000004004e9 in caller () > + # #2 0x00000000004004cd in main () at ... > + gdb_test "bt" \ > + "#0 +callback \[^\r\n\]+\r\n#1 \[^\r\n\]+ in caller \[^\r\n\]+\r\n#2 \[^\r\n\]+ in main \[^\r\n\]+" \ > + "verify unwindin works for CFI without DIEs" > +}