From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53422 invoked by alias); 8 Aug 2019 11:26:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53414 invoked by uid 89); 8 Aug 2019 11:26:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Aug 2019 11:26:01 +0000 Received: by mail-wm1-f66.google.com with SMTP id g67so2049220wme.1 for ; Thu, 08 Aug 2019 04:26:01 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id x24sm2728772wmh.5.2019.08.08.04.25.58 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 08 Aug 2019 04:25:59 -0700 (PDT) Subject: Re: [PATCH 8/8] Require readline 7 or newer To: Tom Tromey References: <20190806204334.13441-1-tom@tromey.com> <20190806204334.13441-9-tom@tromey.com> <91cf16b4-343b-1d47-ab5c-c8f2127cd4db@redhat.com> <87o910ehgf.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 08 Aug 2019 11:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87o910ehgf.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00194.txt.bz2 On 8/7/19 11:30 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> I'd be much better user experience if this were done at by the > Pedro> build system, at configure time, with AC_TRY_COMPILE, IMO. Something > Pedro> similar to the "GNU regex" check should do it. > > Makes sense. Here's a new patch that addresses this and the NEWS thing. Looks good, thanks. Pedro Alves