From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 92DEC3858431 for ; Fri, 20 Jan 2023 17:00:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92DEC3858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3A7881E0D3; Fri, 20 Jan 2023 12:00:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1674234011; bh=Jfac50PusiNIOhrpdwUdEfuZ3kv8Q9FKP3M3oG0dTkM=; h=Date:Subject:To:References:From:In-Reply-To:From; b=kzabJ/bHizWzJJr8ZUies3LJY6e956aICL2t51pI3zkAlPCImv5KSCvP1e5pF8sxS OTfr5s8e7OwJvriaSwXl9z/ls/7coyjltoD26zmGRYnHZ6wZywEe4CZW8SpBwRSTZJ aPPPWlzjaE0Of0ED9j/gwotDuC/rM0j9kyF5ekVw= Message-ID: Date: Fri, 20 Jan 2023 12:00:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] Make gdb.ada/ptype_tagged_param.exp pass Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230119163150.492922-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20230119163150.492922-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/19/23 11:31, Tom Tromey via Gdb-patches wrote: > gdb.ada/ptype_tagged_param.exp is failing for me on x86-64 Fedora 36. > However, it's actually generating the correct output -- it is just > that the test thinks that the "ptype" will not work because I do not > have the GNAT debuginfo installed. > > This patch changes the code to accept either result, and then to issue > a kfail as appropriate. I introduced that code in 2019, saying: Currently the test fails when when running against a GNAT runtime without debug info. This is the case, for example, on Arch Linux using the distribution package. However, now, on the same system (but obviously not the same package versions, as I keep it up to date), I see the same as you: (gdb) ptype s type = new pck.shape with record r: integer; end record (gdb) FAIL: gdb.ada/ptype_tagged_param.exp: ptype s, without debug info Do you know what could have changed? New improved DWARF info from a newer compiler? In any case, your change LGTM, since it will still cause a fail if we do have debug info but see the bad output. Simon