From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id A633438582A2 for ; Tue, 25 Oct 2022 09:26:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A633438582A2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id a14so16994495wru.5 for ; Tue, 25 Oct 2022 02:26:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S3rg7dhPnCzXLgvGyDKdtniiOG6kfjcY8Rv4oWRA6uA=; b=U/IySsLkcyrEh8NDHOzb4531QqFHYdalbdu440ZnqfQ9Bb0LsKAmJJUSKNcewxjM3z FW+K3mMTW+Fte+fp6fTUMyqdUeM9IPuxG0xWyaf37+P+ddNHIUROs1N4io1Naguxm0MM G/F9ruiTAjueDXRNw5Vm/ye9Cg5KO1i9i7SzfZd+8Y3IBXWVBCpc6JIdH4psGdKjB19I LSMQ6GNVvsQN4mz8aXFrzRyvMLDsfF01VnlIplj7Yp2Vj6WFLipN11VdFMQA7Q+yDjnd IKx4TzyxOHj9eohfxDaCvZQ8w/UGF0tG3QQbvOuT8pBCeHHEzDJa9RyJWFzkxJPHF36L JApw== X-Gm-Message-State: ACrzQf1vuNht8Y2TgvenxP0VU0vzgTNdcOwWAFs1/AVhMzr4URsHrG42 9jKgIYmGQxhkXJxgEDMwUnmCedDQ3fMX2A== X-Google-Smtp-Source: AMsMyM7ZpOVU+Xkkdo8E39soX55JE/T8JVHZBCEi5LRT2KOoMTa8H9dBLYbMlcpsrUgrO7oLUBAgXQ== X-Received: by 2002:a5d:6743:0:b0:236:6301:918 with SMTP id l3-20020a5d6743000000b0023663010918mr10300785wrw.247.1666690011014; Tue, 25 Oct 2022 02:26:51 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653? ([2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653]) by smtp.gmail.com with ESMTPSA id c11-20020a05600c0a4b00b003c6f27d275dsm11118534wmq.33.2022.10.25.02.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Oct 2022 02:26:50 -0700 (PDT) Subject: Re: [PATCH 2/2] [gdb] Fix rethrow exception slicing in insert_bp_location To: Tom de Vries , gdb-patches@sourceware.org References: <20221024084913.19429-1-tdevries@suse.de> <20221024084913.19429-3-tdevries@suse.de> <02ad6f69-2a1b-b938-0ab4-ba6288f10fde@suse.de> <0203ad6e-426f-3e8f-fac8-1d2f0e8781a6@palves.net> <546f7fe4-7caa-4b78-bfd5-19480d60420e@suse.de> From: Pedro Alves Message-ID: Date: Tue, 25 Oct 2022 10:26:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <546f7fe4-7caa-4b78-bfd5-19480d60420e@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-25 8:14 a.m., Tom de Vries wrote: > On 10/24/22 18:51, Pedro Alves wrote: >> On 2022-10-24 5:43 p.m., Tom de Vries wrote: >>> On 10/24/22 18:36, Pedro Alves wrote: >>>> On 2022-10-24 9:49 a.m., Tom de Vries via Gdb-patches wrote: >>>> Is there a reason this is a macro instead of a function? >>> >>> yes, the throw without expression. >>> >>> Do you know of a way to do this using a function? >> >> WDYM?  I believe it should Just Work.  E.g.: ... > Hmm, it does indeed, I didn't realize this was possible. > > Fixed in attached patch. > > Any further comments? Nope, looks fine. Thanks, Pedro Alves