From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124877 invoked by alias); 28 Jun 2017 17:42:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124778 invoked by uid 89); 28 Jun 2017 17:42:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 17:42:51 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CA99C0467C0; Wed, 28 Jun 2017 17:42:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6CA99C0467C0 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6CA99C0467C0 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA10B7ABE1; Wed, 28 Jun 2017 17:42:49 +0000 (UTC) Subject: Re: [PATCH 09/25] Use target_desc fields expedite_regs and xmltarget ifndef IN_PROCESS_AGENT To: Yao Qi , gdb-patches@sourceware.org References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-10-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Wed, 28 Jun 2017 17:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-06/txt/msg00769.txt.bz2 On 06/28/2017 05:15 PM, Pedro Alves wrote: > On 06/12/2017 09:41 AM, Yao Qi wrote: >> struct target_desc is used by both GDBserver and IPA, but fields expedite_regs >> and xmltarget are only used in GDBserver, so this patch wraps these two fields >> by ifndef IN_PROCESS_AGENT. This patch also changes regformats/regdat.sh to >> generate .c files in this way too. > > OK. Actually, I tried building the series at some intermediate patch, and noticed that the build was broken. This is the first patch that breaks it: ... amd64-linux.c: In function ‘void init_registers_amd64_linux()’: amd64-linux.c:103:11: error: ‘struct target_desc’ has no member named ‘expedite_regs’ result->expedite_regs = expedite_regs_amd64_linux; ^ amd64-linux.c:104:11: error: ‘struct target_desc’ has no member named ‘xmltarget’ result->xmltarget = xmltarget_amd64_linux; ^ ... Thanks, Pedro Alves