From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Fix problem exposed by gdb.server/stop-reply-no-thread-multi.exp
Date: Wed, 17 Mar 2021 11:27:48 -0400 [thread overview]
Message-ID: <caae9845-c472-6f18-132c-ab824f860778@polymtl.ca> (raw)
In-Reply-To: <20210315234339.457551-4-pedro@palves.net>
On 2021-03-15 7:43 p.m., Pedro Alves wrote:
> Running gdb.server/stop-reply-no-thread-multi.exp with "maint set
> target-non-stop on" occasionally hit an internal error like this:
>
> ...
> continue
> Continuing.
> warning: multi-threaded target stopped without sending a thread-id, using first non-exited thread
> /home/pedro/gdb/binutils-gdb/src/gdb/inferior.c:291: internal-error: inferior* find_inferior_pid(process_stratum_target*, int): Assertion `pid != 0' failed.
> A problem internal to GDB has been detected,
> further debugging may prove unreliable.
>
> This is a bug, please report it.
> FAIL: gdb.server/stop-reply-no-thread-multi.exp: to_disable=Tthread: continue until exit (GDB internal error)
>
> The backtrace looks like this:
>
> ...
> #5 0x0000560357b0879c in internal_error (file=0x560357be6c18 "/home/pedro/gdb/binutils-gdb/src/gdb/inferior.c", line=291, fmt=0x560357be6b21 "%s: Assertion `%s' failed.") at /home/pedro/gdb/binutils-gdb/src/gdbsupport/errors.cc:55
> #6 0x000056035762061b in find_inferior_pid (targ=0x5603596e9560, pid=0) at /home/pedro/gdb/binutils-gdb/src/gdb/inferior.c:291
> #7 0x00005603576206e6 in find_inferior_ptid (targ=0x5603596e9560, ptid=...) at /home/pedro/gdb/binutils-gdb/src/gdb/inferior.c:305
> #8 0x00005603577d43ed in remote_target::check_pending_events_prevent_wildcard_vcont (this=0x5603596e9560, may_global_wildcard=0x7fff84fb05f0) at /home/pedro/gdb/binutils-gdb/src/gdb/remote.c:7215
> #9 0x00005603577d2a9c in remote_target::commit_resumed (this=0x5603596e9560) at /home/pedro/gdb/binutils-gdb/src/gdb/remote.c:6680
> ...
>
> pid is 0 in this case because the queued event is a process exit event
> with no pid associated:
>
> (top-gdb) p event->ws
> During symbol reading: .debug_line address at offset 0x563c9a is 0 [in module /home/pedro/gdb/binutils-gdb/build/gdb/gdb]
> $1 = {kind = TARGET_WAITKIND_EXITED, value = {integer = 0, sig = GDB_SIGNAL_0, related_pid = {m_pid = 0, m_lwp = 0, m_tid = 0}, execd_pathname = 0x0, syscall_number = 0}}
> (top-gdb)
>
> This fixes it.
Makes sense. Since people very rarely run the testsuite with "maint set
target-non-stop on", should the test be adjusted to try in that
configuration as well by default? I know we can't make all tests test
all configurations, but it seems to me like this one has good potential
to uncover other problems.
Simon
next prev parent reply other threads:[~2021-03-17 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 23:43 [PATCH 0/3] Fix gdbserver + "maint set target-non-stop" problems Pedro Alves
2021-03-15 23:43 ` [PATCH 1/3] Fix any_thread_of_inferior Pedro Alves
2021-03-17 15:14 ` Simon Marchi
2021-03-19 19:37 ` Pedro Alves
2021-03-15 23:43 ` [PATCH 2/3] Fix bkpt-other-inferior.exp race Pedro Alves
2021-03-17 15:12 ` Simon Marchi
2021-03-19 19:11 ` Pedro Alves
2021-03-25 17:24 ` Simon Marchi
2021-03-15 23:43 ` [PATCH 3/3] Fix problem exposed by gdb.server/stop-reply-no-thread-multi.exp Pedro Alves
2021-03-17 15:27 ` Simon Marchi [this message]
2021-03-19 19:32 ` Pedro Alves
2021-03-25 17:25 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caae9845-c472-6f18-132c-ab824f860778@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).