Re: [PATCH 2/2] [gdb/symtab] Add maint expand-symtabs -verbose

[Simon Marchi <simon.marchi@polymtl.ca>]

> diff --git a/gdb/symmisc.c b/gdb/symmisc.c
> index e38ceb6bda1..7597487201e 100644
> --- a/gdb/symmisc.c
> +++ b/gdb/symmisc.c
> @@ -904,6 +904,7 @@ maintenance_check_symtabs (const char *ignore, int from_tty)
>  static void
>  maintenance_expand_symtabs (const char *args, int from_tty)
>  {
> +  bool verbose = args != nullptr && check_for_argument (&args, "-verbose");

IWBN to use gdb::option::process_options for any new option we add.

>    char *regexp = NULL;
>  
>    /* We use buildargv here so that we handle spaces in the regexp
> @@ -923,6 +924,17 @@ maintenance_expand_symtabs (const char *args, int from_tty)
>    if (regexp)
>      re_comp (regexp);
>  
> +  auto on_expansion = [&] (compunit_symtab *symtab)
> +  {
> +    if (verbose)
> +      printf_filtered ("Expanded symtab for file %s at %s\n",
> +		       symtab_to_fullname (COMPUNIT_FILETABS (symtab)),
> +		       host_address_to_string (symtab));
> +
> +    /* Keep going.  */
> +    return true;
> +  };

I think we usually format them with one more indentation level, as if it was
a control flow structure:

  auto on_expansion = [&] (compunit_symtab *symtab)
    {
      ...
    }

Simon