public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Bruno Larsen <blarsen@redhat.com>, gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 1/3] [gdb/tui] Keep inferior output in cmd window with ^L
Date: Wed, 31 May 2023 16:19:43 +0200	[thread overview]
Message-ID: <cae72e8f-d8f3-2034-ef03-52a0587abbe5@suse.de> (raw)
In-Reply-To: <335f3833-a4ac-e85a-63ac-5212931cc206@redhat.com>

On 5/31/23 15:35, Bruno Larsen wrote:
> I can confirm that this fixes the issue you mentioned when the terminal 
> scrolls. The problem is that now, if the output doesn't cause the screen 
> to scroll, it doesn't show up on screen at all.

Is it possible that you're talking about a pre-existing issue?

That is, we have:
...
(gdb) next
...
and after <enter> we have very, very briefly:
...
(gdb) next<enter>
hello
...
before the prompt overwrites it:
...
(gdb) next<enter>
(gdb)
...

I get this behaviour with and without the patch series.  AFAIU, the only 
way to deal with this (that doesn't go all the way into introducing 
pseudo-terminals) is by introducing a separate cmd and output window in 
TUI.  Alternatively, we can move the prompt to the bottom of the command 
window, I've spent a day or so trying to make that work, but abandoned that.

If this is not the behaviour you're talking about, please describe a way 
of reproducing what you observe.

Anyway, another way of showing the effect of the patch series in the 
no-scrolling-case is to add an extra hello to the test-case, and do 
"next 2".

Without the patch series we have:
...
(gdb) next 2
(gdb)
hello
...
and after ^L just:
...
(gdb) next 2
(gdb)
...

With the patch series the same:
...
(gdb) n 2
(gdb)
hello
...
and the same after ^L.

Thanks,
- Tom

  reply	other threads:[~2023-05-31 14:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 10:53 [PATCH 0/3] [gdb/tui] Improve handling of inferior output Tom de Vries
2023-05-30 10:53 ` [PATCH 1/3] [gdb/tui] Keep inferior output in cmd window with ^L Tom de Vries
2023-05-31 13:35   ` Bruno Larsen
2023-05-31 14:19     ` Tom de Vries [this message]
2023-05-31 14:27       ` Bruno Larsen
2023-05-31 15:24         ` Tom de Vries
2023-05-31 15:27           ` Bruno Larsen
2023-05-31 23:37       ` Tom de Vries
2023-05-30 10:53 ` [PATCH 2/3] [gdb] Add observable terminal_owner_changed Tom de Vries
2023-05-30 10:53 ` [PATCH 3/3] [gdb/tui] Refresh on target_terminal_state::is_ours Tom de Vries
2023-05-31 14:18   ` Bruno Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cae72e8f-d8f3-2034-ef03-52a0587abbe5@suse.de \
    --to=tdevries@suse.de \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).