From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 7E5EE3858C50 for ; Tue, 12 Jul 2022 11:46:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E5EE3858C50 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C02BF1FA40 for ; Tue, 12 Jul 2022 11:46:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B123D13638 for ; Tue, 12 Jul 2022 11:46:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fNwFKgdfzWJjEgAAMHmgww (envelope-from ) for ; Tue, 12 Jul 2022 11:46:15 +0000 Message-ID: Date: Tue, 12 Jul 2022 13:46:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: [committed][gdb] Add tsan-suppressions.txt Content-Language: en-US From: Tom de Vries To: gdb-patches@sourceware.org References: <20220711100825.GA15997@delia.home> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 11:46:18 -0000 On 7/12/22 12:31, Tom de Vries wrote: > On 7/12/22 10:39, Tom de Vries wrote: >> On 7/11/22 12:08, Tom de Vries wrote: >>> Hi, >>> >>> Add a new file tsan-suppressions.txt, to suppress the "unlock >>> unlocked mutex" >>> problem in ncurses, filed in PR29328. >>> >>> For now, one needs to specify it manually using something like: >>> ... >>> $ export TSAN_OPTIONS=suppressions=$(pwd >>> -P)/src/gdb/tsan-suppressions.txt >>> ... >>> >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29328 >>> >>> Any comments? >>> >> >> I just found that we already set ASAN_OPTIONS in lib/gdb.exp, so I've >> added this TSAN_OPTIONS setting alongside. > > I furthermore realized that suppression files are not cumulative, so if > we have suppressions=a.txt:suppressions=b.txt then only b.txt is used. > > This would mean we ignore any user-specified suppression files, which > may contains more suppressions for whatever reason. > > So I've updated the patch to only add the suppressions if the user > didn't already do that. Well, that makes the whole thing harmless enough, so committed. Thanks, - Tom