From: Pedro Alves <pedro@palves.net>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/3] Capitalize output of successful checkpoint command
Date: Fri, 3 May 2024 16:54:54 +0100 [thread overview]
Message-ID: <cb4b6342-4121-4aaf-a324-02ed68358de4@palves.net> (raw)
In-Reply-To: <20240414195812.151224-3-kevinb@redhat.com>
On 2024-04-14 20:44, Kevin Buettner wrote:
> This commit causes the output of a "checkpoint" command to be
> changed from:
>
> checkpoint N: fork returned pid DDDD
>
> to:
>
> Checkpoint N: fork returned pid DDDD
>
> This change was made to bring the output of the "checkpoint" command in
> line with that of other commands, e.g.:
>
> (gdb) break main
> Breakpoint 1 at ...
>
> (gdb) catch exec
> Catchpoint 2 (exec)
>
> (gdb) add-inferior
> [New inferior 2]
> Added inferior 2
>
> The tests gdb.base/checkpoint.exp and gdb.base/kill-during-detach.exp
> have been updated to accept either form of output from the
> "checkpoint" command.
Why either instead of just uppercase?
> The test gdb.multi/checkpoint-multi.exp had
> already been written with this change in mind.
Ah, yeah,that answers the question I made there.
next prev parent reply other threads:[~2024-05-03 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 19:44 [PATCH v3 0/3] Make linux checkpoints work with multiple inferiors Kevin Buettner
2024-04-14 19:44 ` [PATCH v3 1/3] " Kevin Buettner
2024-05-03 15:54 ` Pedro Alves
2024-04-14 19:44 ` [PATCH v3 2/3] Capitalize output of successful checkpoint command Kevin Buettner
2024-05-03 15:54 ` Pedro Alves [this message]
2024-04-14 19:44 ` [PATCH v3 3/3] Make thread_db_target::pid_to_str checkpoint-aware Kevin Buettner
2024-05-03 15:55 ` Pedro Alves
2024-05-02 1:49 ` [PATCH v3 0/3] Make linux checkpoints work with multiple inferiors Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb4b6342-4121-4aaf-a324-02ed68358de4@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).