From: Simon Marchi <simon.marchi@polymtl.ca>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: GDB 7.99.91 available for testing
Date: Tue, 16 May 2017 21:22:00 -0000 [thread overview]
Message-ID: <cb697370379cc39c0b9446ed63f2de9e@polymtl.ca> (raw)
In-Reply-To: <20170516204954.zbv35vjzsqa3qenf@localhost>
On 2017-05-16 16:49, Yao Qi wrote:
> On 17-05-16 09:51:42, Simon Marchi wrote:
>>
>> So indeed, the problem is due to the ordering of the _initialize
>> functions
>> that changed, _initialize_printcmd used to be called before
>> _initialize_infcmd, now it's the reverse.
>>
>> When it works, the timeline of events to be able to get the tty alias
>> working is the following:
>>
>> 1. The "set" command is registered as a prefix command in printcmd.c,
>> which
>> adds it to the global command list (cmdlist). setlist is the list of
>> its
>> subcommands.
>> 2. The "set inferior-tty" command is added as a child of "set" (i.e.
>> it's
>> inserted into setlist) in infcmd.c.
>> 3. The "tty" alias is created for "set inferior-tty" in infcmd.c.
>> This
>> looks up "set" in cmdlist, then "inferior-tty" in the subcommands of
>> "set".
>> It's found and everyone is happy.
>>
>> With the _initialize functions called in a different order, steps are
>> executed in the order 2-3-1. When we try to create the alias, the
>> "set"
>> command has not been created and is therefore not part of cmdlist. We
>> can't
>> find the "set inferior-tty" command, so the alias is not created.
>
> When we try to create the alias (in step 3), setlist is already created
> in step 2, but it is not linked with cmdlist. The command "set
> inferior-tty" is created in step 2 too. Since step 2 and step 3 are
> close to each other (in _initialize_infcmd), we can pass the "set
> inferior-tty" cmd_list_element to the place we create alias, like this,
>
> cmd_name = "inferior-tty";
> c = lookup_cmd (&cmd_name, setlist, "", -1, 1);
> gdb_assert (c != NULL);
> add_alias_cmd ("tty", c, class_alias, 0, &cmdlist);
>
> this makes sure we add alias "tty" under cmdlist, and it is alias to
> "set inferior-tty". Step 1 just links setlist and cmdlist together.
>
>>
>> I think the core issue is that it's currently possible to create
>> subcommands
>> for prefixes that have not been created yet. We need some way of
>> ensuring
>> some kind of ordering. Here are some ideas:
>>
>
> How is the patch below? I run regress tests yet, and it still needs
> some comments.
It's very clean, I like it. I think it's good for master and 8.0. Do
you want to finish it or do you want me to pick it up?
I have enhanced gdb.base/set-inferior-tty.exp to exercise the alias, it
could be added to your patch:
https://github.com/simark/binutils-gdb/commit/1a8bcb5dbc0dde3d8a4d3f73d0a057b3831902dd#diff-2f94d545bf202185ae6a6022ebfa93bc
Thanks,
Simon
next prev parent reply other threads:[~2017-05-16 21:22 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 19:44 Joel Brobecker
2017-05-08 14:53 ` Eli Zaretskii
2017-05-17 11:36 ` Yao Qi
2017-05-17 14:39 ` Eli Zaretskii
2017-05-08 15:00 ` GDB 7.99.91 MinGW compilation error in cli-script.c Eli Zaretskii
2017-05-14 3:19 ` Simon Marchi
2017-05-14 14:13 ` Eli Zaretskii
2017-05-17 14:31 ` Joel Brobecker
2017-05-17 16:01 ` Eli Zaretskii
2017-05-19 9:10 ` Eli Zaretskii
2017-05-19 9:49 ` Pedro Alves
2017-05-19 11:17 ` Eli Zaretskii
2017-05-19 11:23 ` Pedro Alves
2017-05-21 15:33 ` Eli Zaretskii
2017-05-22 15:26 ` Pedro Alves
2017-05-22 18:43 ` Eli Zaretskii
2017-05-23 9:53 ` Pedro Alves
2017-05-24 2:44 ` Eli Zaretskii
2017-05-25 10:05 ` Pedro Alves
2017-05-26 7:57 ` Eli Zaretskii
2017-05-26 11:52 ` Pedro Alves
2017-05-26 12:57 ` Eli Zaretskii
2017-05-26 13:58 ` Pedro Alves
2017-05-24 18:28 ` Eli Zaretskii
2017-05-24 19:37 ` Joel Brobecker
2017-05-25 10:12 ` Pedro Alves
2017-05-26 7:47 ` Eli Zaretskii
2017-05-26 10:54 ` Pedro Alves
2017-05-26 13:03 ` Eli Zaretskii
2017-05-26 14:10 ` Pedro Alves
2017-05-26 14:35 ` Eli Zaretskii
2017-05-26 14:45 ` Pedro Alves
2017-05-08 15:02 ` GDB 7.99.91 MinGW compilation warning in tui.c Eli Zaretskii
2017-05-09 10:17 ` Yao Qi
2017-05-13 8:12 ` Eli Zaretskii
2017-05-17 16:26 ` Yao Qi
2017-05-17 16:45 ` Eli Zaretskii
2017-05-17 18:21 ` Joel Brobecker
2017-05-19 8:02 ` Eli Zaretskii
2017-05-19 9:54 ` Pedro Alves
2017-05-19 11:14 ` Eli Zaretskii
2017-05-19 11:25 ` Pedro Alves
2017-05-19 12:51 ` Eli Zaretskii
2017-05-19 13:58 ` Pedro Alves
2017-05-19 14:40 ` Eli Zaretskii
2017-05-19 17:50 ` DJ Delorie
2017-05-19 17:55 ` Eli Zaretskii
2017-05-15 21:11 ` GDB 7.99.91 available for testing Simon Marchi
2017-05-16 13:51 ` Simon Marchi
2017-05-16 20:50 ` Yao Qi
2017-05-16 21:22 ` Simon Marchi [this message]
2017-05-16 21:40 ` Yao Qi
2017-05-17 11:31 ` [PATCH master/8.0] Add alias command to cmd_list_element Yao Qi
2017-05-17 12:16 ` Simon Marchi
2017-05-17 13:36 ` Yao Qi
2017-05-16 14:28 ` GDB 7.99.91 available for testing Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb697370379cc39c0b9446ed63f2de9e@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).