public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: James Clarke <jrtc27@jrtc27.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver
Date: Fri, 19 Jan 2018 16:57:00 -0000	[thread overview]
Message-ID: <cb6a27cd-64ac-c0d5-9ccb-619ad14d93bc@redhat.com> (raw)
In-Reply-To: <1BA91B1E-5E4A-4084-822C-3A35ADB4390C@jrtc27.com>

On 01/19/2018 04:55 PM, James Clarke wrote:
> On 19 Jan 2018, at 16:48, Pedro Alves <palves@redhat.com> wrote:
>> On 12/15/2017 12:04 AM, James Clarke wrote:
>>> gdb/ChangeLog:
>>> 	* gdbserver/linux-low.c (handle_extended_wait): Surround call to
>>> 	thread_db_notice_clone with #ifdef USE_THREAD_DB.
>>> ---
>>> [Originally erroneously sent to the binutils mailing list]
>>
>> Looks OK, but could you remind me what goes wrong if we
>> don't do this?  Does gdbserver fail to link?
> 
> Yes, with the expected:
> 
>> [...]/linux-low.c:664: undefined reference to `thread_db_notice_clone(thread_info*, ptid_t)'
> 
> Every other use of thread_db_* is guarded by USE_THREAD_DB, so I assume it's
> fine to do here too.

Thanks for the clarification.  Please add that to the commit log,
and push it in.

Thanks,
Pedro Alves

  reply	other threads:[~2018-01-19 16:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15  0:04 [PATCH 1/2] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h James Clarke
2017-12-15  0:04 ` [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver James Clarke
2018-01-19 16:48   ` Pedro Alves
2018-01-19 16:55     ` James Clarke
2018-01-19 16:57       ` Pedro Alves [this message]
2018-01-19 17:01         ` James Clarke
2018-01-19 16:34 ` [PATCH 1/2] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h James Clarke
2018-01-19 16:43 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb6a27cd-64ac-c0d5-9ccb-619ad14d93bc@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jrtc27@jrtc27.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).