From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C738A3830B0A for ; Thu, 24 Nov 2022 15:14:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C738A3830B0A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2AOFEKWW015345 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Nov 2022 10:14:24 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2AOFEKWW015345 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1669302865; bh=oioIwK7TJFFzMRFkiXPeO6iKDpVyCkS4rEJ1iLi8aVY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=VGvwZiKXSDBzDL9OlG+LBgUtKC5mBiybdU+hZqmz2xMRTc//5hVMoWqaUShYTfCLK +K76D1h4l3z0z5avQK4xX1h8LRI/cR740+3aPqKxbCi5IRsLLWAvyY0i3AyitdNGby nOPCBMxrypb295Vy9PTlw/LaRwFciUGxr1Gk8Dzg= Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CE5E71E11A; Thu, 24 Nov 2022 10:14:19 -0500 (EST) Message-ID: Date: Thu, 24 Nov 2022 10:14:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 00/14] Break up gdb.base/break.exp in multiple procs Content-Language: fr To: Kevin Buettner , Simon Marchi via Gdb-patches References: <20221123183959.2476477-1-simon.marchi@polymtl.ca> <20221123200302.34d78f05@f35-zws-nvidia> From: Simon Marchi In-Reply-To: <20221123200302.34d78f05@f35-zws-nvidia> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 24 Nov 2022 15:14:20 +0000 X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/23/22 22:03, Kevin Buettner wrote: > Hi Simon, > > On Wed, 23 Nov 2022 13:39:45 -0500 > Simon Marchi via Gdb-patches wrote: > >> The test gdb.base/break.exp feels like a big house of cards that will >> crumble the second you touch it. It is very long and it's really not >> clear which test depends on the state left by which previous test. This >> series aims at making it more manageable by breaking it up into many >> procs, each starting with a fresh GDB. So you can be confident that the >> tests in a proc only depends on the state of GDB resulting of other >> tests in the same proc. >> >> Simon Marchi (14): >> gdb/testsuite/gdb.base/break.exp: split test_break_commands_clear >> gdb/testsuite/gdb.base/break.exp: split >> test_break_file_line_convenience_var >> gdb/testsuite/gdb.base/break.exp: split test_rbreak_shlib >> gdb/testsuite/gdb.base/break.exp: split test_break_optimized_prologue >> gdb/testsuite/gdb.base/break.exp: use proc_with_prefix for >> test_next_with_recursion >> gdb/testsuite/gdb.base/break.exp: split test_finish_arguments >> gdb/testsuite/gdb.base/break.exp: split test_break_user_call >> gdb/testsuite/gdb.base/break.exp: split >> test_break_line_convenience_var >> gdb/testsuite/gdb.base/break.exp: split test_break_silent_and_more >> gdb/testsuite/gdb.base/break.exp: split test_break_default >> gdb/testsuite/gdb.base/break.exp: split test_break_nonexistent_line >> gdb/testsuite/gdb.base/break.exp: split test_no_break_on_catchpoint >> gdb/testsuite/gdb.base/break.exp: split test_tbreak >> gdb/testsuite/gdb.base/break.exp: split test_break >> >> gdb/testsuite/gdb.base/break.exp | 1191 +++++++++++++++--------------- >> 1 file changed, 615 insertions(+), 576 deletions(-) > > Thanks for doing this! > > I looked at each patch in this series. LGTM. > > Kevin > Thanks, will add you Approved-By and push. Simon