From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 9FF053858422 for ; Fri, 19 Nov 2021 01:17:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FF053858422 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.130.0.135] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dxj88q+5ZhFlYAAA--.1516S3; Fri, 19 Nov 2021 09:17:30 +0800 (CST) Subject: Re: [PATCH 2/2] gdb: testsuite: specify two args for "set args" command in a2-run.exp To: Tom Tromey References: <1637236761-7973-1-git-send-email-yangtiezhu@loongson.cn> <1637236761-7973-3-git-send-email-yangtiezhu@loongson.cn> <8735ntbhzr.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Tiezhu Yang Message-ID: Date: Fri, 19 Nov 2021 09:17:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8735ntbhzr.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf9Dxj88q+5ZhFlYAAA--.1516S3 X-Coremail-Antispam: 1UD129KBjvJXoWxXF4xJF1DCw13Ary3ZFWfuFg_yoW5Kr13pF 47t3y0yF1rXF42qr1rtr1UC3s5Ar4Sy34F93yfJr42vFn5GrWUA34UK348Ar15Xryvqr1f Cw4xA3ZxZ3s8AFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvqb7Iv0xC_KF4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjc xK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG 64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2jsIE14v26r 4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vI Y487MxkIecxEwVAFwVWkMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI 8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AK xVWUXVWUAwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI 8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E 87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0x ZFpf9x07jz4E_UUUUU= X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2021 01:17:35 -0000 On 11/18/2021 11:28 PM, Tom Tromey wrote: >>>>>> ">" == Tiezhu Yang writes: >>> In order to improve test coverage, add a testcase to specify two args >>> for "set args" command in a2-run.exp. > When you say to improve coverage -- did you do before/after coverage > runs and see some improvement? If so, could you say where? > > I tend to suspect there are other spots testing 'set args'. > > thanks, > Tom Hi Tom, Thank you very much for your reply. It was intended to test the following case in gdb/testsuite/gdb.base/run.c: if (argc != 2) { printf ("usage: factorial \n"); return 1; } Additionally, I do not find a test case with two args for "set args"command, maybe am I missing something? $ grep -r "set args"gdb/testsuite/gdb.base gdb/testsuite/gdb.base/gdb_history:set args gdb/testsuite/gdb.base/setshow.exp: gdb_test_no_output "set args ~" gdb/testsuite/gdb.base/setshow.exp: #test set args gdb/testsuite/gdb.base/setshow.exp: gdb_test_no_output "set args foo bar blup baz bubble""set args" gdb/testsuite/gdb.base/jit-elf-so.exp: # Poke desired values directly into inferior instead of using "set args" gdb/testsuite/gdb.base/jit-elf-so.exp: # because "set args"does not work under gdbserver. gdb/testsuite/gdb.base/sigbpt.exp: set args [concat $args "*[at_segv]"] gdb/testsuite/gdb.base/inferior-args.exp: } elseif { $method == "set args"} { gdb/testsuite/gdb.base/inferior-args.exp: # Using "set args"does not make sense with a stub. gdb/testsuite/gdb.base/inferior-args.exp: gdb_test_no_output "set args $inferior_args" gdb/testsuite/gdb.base/inferior-args.exp:foreach_with_prefix method { "start""starti""run""set args"} { gdb/testsuite/gdb.base/jit-elf.exp: # Poke desired values directly into inferior instead of using "set args" gdb/testsuite/gdb.base/jit-elf.exp: # because "set args"does not work under gdbserver. gdb/testsuite/gdb.base/a2-run.exp:# Use "set args"command to specify no arguments as default and run again. gdb/testsuite/gdb.base/a2-run.exp:gdb_test_no_output "set args" gdb/testsuite/gdb.base/a2-run.exp:# Use "set args"command to specify an argument and run again. gdb/testsuite/gdb.base/a2-run.exp:gdb_test_no_output "set args 6" gdb/testsuite/gdb.base/info-proc.exp:# cmdline". However, if we're using a stub, then "set args" would not gdb/testsuite/gdb.base/info-proc.exp: gdb_test_no_output "set args $cmdline""set args" gdb/testsuite/gdb.base/gcore-buffer-overflow.exp:gdb_test_no_output "set args ${pattern}"\ gdb/testsuite/gdb.base/pie-execl.exp:# In remote mode we cannot use the 'set args'command, and this gdb/testsuite/gdb.base/pie-execl.exp:gdb_test_no_output "set args ${binfile2}""set args ${binfile2_test_msg}" gdb/testsuite/gdb.base/break-interp.exp: gdb_test_no_output "set args segv" gdb/testsuite/gdb.base/break-interp.exp: gdb_test_no_output "set args [standard_output_file $binfile_test]"\ gdb/testsuite/gdb.base/break-interp.exp: "set args OBJDIR/${subdir}/$binfile_test" gdb/testsuite/gdb.base/default.exp:#test set args gdb/testsuite/gdb.base/default.exp:gdb_test_no_output "set args""set args" gdb/testsuite/gdb.base/startup-with-shell.exp: gdb_test_no_output "set args $run_args"\ gdb/testsuite/gdb.base/startup-with-shell.exp: "set args \$run_args"