Re: [PATCH v3] gdb: Change "list ." command's error when no debuginfo is available

[Pedro Alves <pedro@palves.net>]

On 2024-04-30 19:35, Guinevere Larsen wrote:

>  	      /* The inferior is not running, so reset the current source
>  		 location to the default (usually the main function).  */
>  	      clear_current_source_symtab_and_line ();
> -	      set_default_source_symtab_and_line ();
> -	      cursal = get_current_source_symtab_and_line ();
> +	      try
> +		{
> +		  set_default_source_symtab_and_line ();
> +		}
> +	      catch (const gdb_exception &e)

Catching gdb_exception is usually a red flag.  That catches Ctrl-C and force-quit
 (for SIGTERM) too.  Please don't do that unless there's a good reason.

Maybe we should rename gdb_exception -> gdb_exception_avoid_catching_me.  :-P


> +		{
> +		  error (_("Insufficient debug info for showing source "
> +			   "lines at default location"));

Speaking of catching errors...  This looks brittle -- how can we be sure
that the error is about missing debug info?  Is this all about this error:

 void
 set_default_source_symtab_and_line (void)
 {
   if (!have_full_symbols () && !have_partial_symbols ())
     error (_("No symbol table is loaded.  Use the \"file\" command."));

?

It would be much simpler and clearer to make set_default_source_symtab_and_line
(or a variant of it) return false instead.