From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2045.outbound.protection.outlook.com [40.107.115.45]) by sourceware.org (Postfix) with ESMTPS id 4585A3858C52 for ; Thu, 28 Sep 2023 18:24:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4585A3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0A+niuOU7KUsz5P5UoXRSA2yz4H+Jk/fKlDEspwmnowgph2YYt9ENffKpBnvtilGR7ODysjSWQNty+SKv9FoU/tV3+Q6nADma2RldVZTFAigNP+6r1eZQAEbuiKAFNMq3sThe3gTwOuB9mHMwjkhAl0DwMRWdDGGl8zGC95swRmeS3rR3SuQBVquI18R04ZZtpF+RdQAoRNuLHoVjxSJySvFkf/lOArI8IGUb+L6Ip4S4W2V2gNxFdyf1b3hGx6Mxzm2MLND+kbi1aGk/VFc6/D7TENU1Yg1CpKMX9B2outNnep0ik8eidSl4O8m0D2HX632mcXJHRzzizqZOooDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+nJnQP5Tt3b9NvS/jF20DxX9TY8XbZ7M967Az9pTJ80=; b=Vpm+tRWR/peDzL7/PKTA8pOFjdVAxU+igl7P3m9ukaMmpWa22J5t8alo675Acz4HcGyIZZe+eSPjQkLA0NRhaR4UrExb9Bm2e0vu6yl/EMHp01mhExe6UaIz/tF6F1+KzMkQekfV9SOac8A5upuSvvb0hh4vAZDyPwNQjctWX00nVSm7/ccvGonD05kkjxez7lpJ3u9+CEwatzKalHX4DhTrjDm2wQQx6Z+1wcvHt22Z5ECbFc52Alp7SwJH5mIjTAx1MGeNb8UU7OI4RvSm26gJBh2qMGwT6eqfniSJPJpIqzl4DlowHSSD1e1ZG1QYwGDxCMv79vz0SOMF43RwNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+nJnQP5Tt3b9NvS/jF20DxX9TY8XbZ7M967Az9pTJ80=; b=mWRneBMmE9yQRUIFNYCkGzkusmqmK+1OKObNqoSKBEBURjUpKc1VDEh5QeZ9oV/7R/zgD7nYceIiGE1ibxNr1BYl+Re1V6Dp0SSCxh5jDDt/2Zd7A50XFKwpOtzmSYE1TYwm4dw9Y6GLGR+CI0VSYLxb2+GCjq7hvKU708CeLw5N7IRRCELa6fIw/oZYalXTGiEO3lqMwqUAIOfvy2F/S9dPC1uKGpVjYGUXoApoPdO9BEfLSGkeSVxLekSAc55Kyen3HgXErWiNZJ361EkiIa/khvGPu15bOF11cO7IAYq2dSuddZQzEhhbitbcpDbLfnmuG1BN4R+DN8c/7GmYqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB9140.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.21; Thu, 28 Sep 2023 18:24:57 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::46c0:f003:1073:c2a4]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::46c0:f003:1073:c2a4%6]) with mapi id 15.20.6813.017; Thu, 28 Sep 2023 18:24:57 +0000 Message-ID: Date: Thu, 28 Sep 2023 14:24:55 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb: remove nbsd_{ilp32, lp64}_solib_svr4_fetch_link_map_offsets Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20230928174752.389177-1-simon.marchi@efficios.com> <20230928174752.389177-2-simon.marchi@efficios.com> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0014.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01::22) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB9140:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bba359b-597c-48c6-06b5-08dbc05037e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EQ9iqPUSgSur/BLdtzkdil2/tJJgnvhb3mMImx5wwUQx8grnORRAV0UEbK5E13/jFCvFxIVl5MFT6zk7es6x68H9EaTcF0BkRRgfD8vJNJGUUft212WsrgsCzs56NUrT30JOsA5sTNgBMu1dnVp+rkjXPsryv0sJE41O43nCIfgtFfyWjyNIgxt3sJzxtR26AbZM9rIFXvCbTttwS/bVarMPtWRk68spDDES71yEtQYwArYqUCTW5EqF8YnakA/CZkHq79XD5lbcTGq2Q9cOeCUqXwIintlD40na34GP7baOmkyqTA+eq5cxBc3dybFcjiCd6vTLwPlF4Y2yOxtk1ASrC9CTyHdxOL6SeoQehFBNCBltFaSalEp+HfmDFP5aJpqa0SwWiD2h/LyJ6rNnoj/zMcPImFYDStMUHWKjLspdnCO4rLbBKFM6g4TujL2bKnDhPYNIgzgMaToVM/QtCtC204AX+xAdKdFTPfKkfI6+akuBvFKNWTm1ZkorsfTlP5RFo+9giCrsfRkgFku0jSrkExwdOHMPDrw628pOu8dqEPLXB5VhYwZCbsBOEI4jaFtsMRTw16Az+7wfUu9ZTJMvAYfiLTkP4ZdeFAvcu353avf/53DqOLn906KlgH2hLclIVY/f81eTytCLW32zxA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(346002)(396003)(39830400003)(366004)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(31686004)(53546011)(2616005)(26005)(38100700002)(6486002)(36756003)(31696002)(316002)(83380400001)(41300700001)(2906002)(478600001)(6512007)(5660300002)(6506007)(8936002)(66476007)(8676002)(66946007)(66556008)(44832011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkhWM2JrNU01NWFXcHlOcVNlQW5CN1FIRTQrNU0ra2NYNDhtMkhoaDZQY0dI?= =?utf-8?B?QWNhK0N6NlJtV0cyczNwZWZqSXVvb09sY1dUaDZ3TzVHV0Yzck9CeHlUKzh3?= =?utf-8?B?MzZHWHRYVW1lMVBhQXVZYjNVOU1wZmk3OWtqVkZBSnF2emtmM2o3TnFvQzdm?= =?utf-8?B?UXU3RTBhNWRNVk5xdjBWenp4VklkdHY5N3JjUzR3TVBRbUxpaHU5U2hPK2FI?= =?utf-8?B?L09RbjdYOTV5SnY5bWYyMzZnNlY0bnl4cTVsWXNHcWNBcGFISmVoWk14VVVu?= =?utf-8?B?MTlBUVFMZ1cwc2FYVDNPVE96Y0ZGZGIxaU5CcDFLYnRnVTN5WFZqRkVuK01t?= =?utf-8?B?SkZFcTh6OHBGbU1SLzVKOW1JT08xdWJDaC9uckhsSUNyaUEzSE92cWxWWW93?= =?utf-8?B?dVJLbXdhNE1PYVM2c2FEWi84SExDT2lxNGd4NXJaOXR1eGF5d2l1NXRyQnF6?= =?utf-8?B?SW90UnhCK2pYdmtwN2NZUnJRQjM3Q1lRMGlJQXhYbEpWeitsNGN0V3JGV3kz?= =?utf-8?B?MmhDMzNqTkVGL3R4NWFLNUs0NHJnN1k4V21Bc2JYM3ZLWEJVZjduTVpWK3Jv?= =?utf-8?B?UnJyVGFyTlNieFE3WTBjallJbHV6T3hnclhvSlhxeFdlODcydE9ydkFZcXRX?= =?utf-8?B?dEJHM3NtSEFKK1g5bzJldXhMd0FhQWxMTjNRQnFkM0NwNXRDSUxGaFBXRENC?= =?utf-8?B?Wkh3UGRhUzJId2hiM1J6RzI0eHFUdVFNa3hWNFRheWRqVHNXV2NBK1lIa3No?= =?utf-8?B?QVdPRWVHWnh3MENVODN4aDh0Zk41SkhtUVcwdzVXVkYxbWpTV1dUdktIaU1P?= =?utf-8?B?NFY5QWJFYjdoak5JMEhoMjE3VHdUdHlOUVJraDZ4R1ZIeXc0S3VKaWhOODVT?= =?utf-8?B?RVUxdE5mZkRxYmo1a3FONU5JRk1vVlZScldjSWdKank1M2xvZnFhaUhUQnNk?= =?utf-8?B?MWVGMjRwUEZPdzYxVDlxYVk0Z2lVbmIwb1JuM2RxU1FIWng3L0N6bkY2NXpB?= =?utf-8?B?Sk9zN2pyTUNoVWxTYTYrZXNnTm1TL2xTRmJiV1RrOWo1ODI1NVhUMndvMnpn?= =?utf-8?B?eXY0YmJDSVhVK0NTa3BOazB0YUpyc3hDOFRDelViWUEvSVBaTE9DL3BsUWVp?= =?utf-8?B?QlNXNW9NVmRJWXErVmhJZ3lJZmxGaldUWUVreUFZdmcwakdrZ3diam8yWWdp?= =?utf-8?B?Qm5RN3lrZVV3bkdwODR4ZzBVeFVRaDJVSmpLK2tLL1pEUzBRYTVLaC9LZFdt?= =?utf-8?B?aWRCWFExcUU4UHJRaWFQOWwzMTJpdHdiTTJiUE8vVTI4WHA4eDhReEY0UVNW?= =?utf-8?B?MmY0cHR2M3Bza2NQc0t5UjVUbmtSeDQ4UDFHNlNOWGM5WXpMd0dvb2FpVGZo?= =?utf-8?B?cHNwR21FVWhtZEFUMGZuQXdQQXVmbEMvd0dTbzYxN05sVWxtTVhSQjc3cFpN?= =?utf-8?B?eWxMdlllMWptYTV4NWNYQVBxMXV6WVNsR09HMlZoZG42eStLVFB6NGNuYngw?= =?utf-8?B?aG1XSHM1TDQ0TGVVaExUOGl6VW50N3FPRlRnTnV6MnJ6NnBna2ppL0QrWnI0?= =?utf-8?B?c1BHdkxFY0tqSUdRTjhjOHRNb25DSmNuM0IwbXVtRUdqTERnZERIU0J1T1ZV?= =?utf-8?B?d2tWUHhYdzNmRWhER1dOUWNGaFVWNjY1TGRQa0ZmYnlBdXdsRlNsTGZuL2xC?= =?utf-8?B?dTF4SHVGMFQxSW5aTGJiUEk5VGhiWDhaN0FEY1N6YndYMmlvMmwyYUJlNUJD?= =?utf-8?B?aE5UandqNWM0YjBXY1k1b1BwWUFrMHpyTzkyNU16cmhKcEZLL1A3dHZ2RmlQ?= =?utf-8?B?enNJWXZJd2QzZTFXUFNNendtYlJnZ04wZDBxTTU3YU5vbEh2bnFQTzhTdnFL?= =?utf-8?B?OVZoOWNiamw4Z0Eya3VDSzNQdlA4bGR6WlFVVlRwbnlBM2FOaytJZE9UUzFi?= =?utf-8?B?QkNLSXQ2NkVRQUJOQ0pBVCtGU0p5L2RhSWhSdUgrdGxpYUFlNFdMQ3dxTG5r?= =?utf-8?B?SkptQ0NDUkk3Tk1BTlFaZ29qTGdJdm0yUUdwRjlhWDFrd1orN3pURkFZazV2?= =?utf-8?B?NGxCMzY5RFJrM0hPS3lHb0JGd1NpWjliSnp4VlhyaG1wQ3dwLzdITlQyNCt5?= =?utf-8?Q?kBar6bw2GZPrz8XoHq8Tc8L/I?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bba359b-597c-48c6-06b5-08dbc05037e1 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 18:24:57.2590 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 40Az6RxJoy9uQa+QtjQbc1EJie5EfTdXkrccxyjBez5cD2PeNHjvXyBkR3PlaGdcF7fpRmSoojs9QN+lwM1r8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB9140 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/28/23 14:07, John Baldwin wrote: > On 9/28/23 6:47 PM, Simon Marchi via Gdb-patches wrote: >> They are unused. >> >> Change-Id: I9b78837d41126ce1957aa1e8b08c82a422f06cbf >> --- >> gdb/netbsd-tdep.c | 15 --------------- >> gdb/netbsd-tdep.h | 3 --- >> 2 files changed, 18 deletions(-) >> >> diff --git a/gdb/netbsd-tdep.c b/gdb/netbsd-tdep.c >> index ed60200f958b..15a9e2fd7d4e 100644 >> --- a/gdb/netbsd-tdep.c >> +++ b/gdb/netbsd-tdep.c >> @@ -44,21 +44,6 @@ >> #define KINFO_VME_FLAG_GROWS_UP 0x00000010 >> #define KINFO_VME_FLAG_GROWS_DOWN 0x00000020 >> -/* FIXME: kettenis/20060115: We should really eliminate the next two >> - functions completely. */ >> - >> -struct link_map_offsets * >> -nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void) >> -{ >> - return svr4_ilp32_fetch_link_map_offsets (); >> -} >> - >> -struct link_map_offsets * >> -nbsd_lp64_solib_svr4_fetch_link_map_offsets (void) >> -{ >> - return svr4_lp64_fetch_link_map_offsets (); >> -} >> - >> int >> nbsd_pc_in_sigtramp (CORE_ADDR pc, const char *func_name) >> { >> diff --git a/gdb/netbsd-tdep.h b/gdb/netbsd-tdep.h >> index ab13e628d582..2adf9a751e3b 100644 >> --- a/gdb/netbsd-tdep.h >> +++ b/gdb/netbsd-tdep.h >> @@ -20,9 +20,6 @@ >> #ifndef NBSD_TDEP_H >> #define NBSD_TDEP_H >> -struct link_map_offsets *nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void); >> -struct link_map_offsets *nbsd_lp64_solib_svr4_fetch_link_map_offsets (void); >> - >> int nbsd_pc_in_sigtramp (CORE_ADDR, const char *); >> /* NetBSD specific set of ABI-related routines. */ > > Both patches seem sensible to me, and the NetBSD one in particular looks right. Thanks, I will push them (they could have maybe been considered obvious). Can I add your Reviewed-By? Simon