Re: [PATCH 1/2] gdb/testsuite: add simavr.exp board

[Pedro Alves <palves@redhat.com>]

On 5/25/20 2:29 PM, Simon Marchi via Gdb-patches wrote:

> Ah, the issue wasn't really gdb_expect or the regex.
> 
> It's just that gdb_run_cmd expects gdb_reload to return 0 in order
> to proceed:
> 
>  268             if { [gdb_reload] != 0 } {
>  269                 return
>  270             }
> 
> And tcl has this common shell behavior where a procedure returns
> the same thing as the last thing it called, without an explicit
> "return":
> 
> $ cat test.tcl
> proc p1 {} {
>   return 17
> }
> 
> proc p2 {} {
>   p1
> }
> 
> puts [p2]
> $ tclsh test.tcl
> 17
> 

Yeah.

> And gdb_test_multiple just happened to return 0, but gdb_expect
> did not.  Using gdb_expect and adding a `return 0` in my proc
> made it work.
> 

Thanks for digging into it.

> Here's the patch with that fixed:

Don't you want to handle timeout (and maybe unexpected output) in
the new gdb_expect call?

Regardless, this LGTM.  It doesn't impact anything else and can always be
improved afterwards.

Thanks,
Pedro Alves