From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87699 invoked by alias); 17 May 2017 15:43:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87076 invoked by uid 89); 17 May 2017 15:43:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=representative X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 May 2017 15:43:52 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 743E2796E4; Wed, 17 May 2017 15:43:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 743E2796E4 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 743E2796E4 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C76761816F; Wed, 17 May 2017 15:43:52 +0000 (UTC) Subject: Re: [RFC 6/7] Lazily and dynamically create i386-linux target descriptions To: Yao Qi , gdb-patches@sourceware.org References: <1494518105-15412-1-git-send-email-yao.qi@linaro.org> <1494518105-15412-7-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Wed, 17 May 2017 15:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1494518105-15412-7-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00399.txt.bz2 On 05/11/2017 04:55 PM, Yao Qi wrote: > +#if GDB_SELF_TEST > + struct xml_and_mask > + { > + const char *xml_file_name; > + uint64_t mask; > + }; Minor nit: I'd instinctively find it more natural to read the list below as { input, output } (left to right), while you have have { output, input }. > + > + struct xml_and_mask array[] = { > + { "i386/i386-linux.xml", X86_XSTATE_SSE_MASK }, > + { "i386/i386-mmx-linux.xml", X86_XSTATE_X87_MASK }, > + { "i386/i386-avx-linux.xml", X86_XSTATE_AVX_MASK }, > + { "i386/i386-mpx-linux.xml", X86_XSTATE_MPX_MASK }, > + { "i386/i386-avx-mpx-linux.xml", X86_XSTATE_AVX_MPX_MASK }, > + { "i386/i386-avx-avx512-linux.xml", X86_XSTATE_AVX_AVX512_MASK }, > + { "i386/i386-avx-mpx-avx512-pku-linux.xml", > + X86_XSTATE_AVX_MPX_AVX512_PKU_MASK }, About these xml files. Is your idea that: #1 - we remove these xml description files at some point, keeping only the description fragments which are currently xi:included by the xml files above? #2 - or, we'll still continue adding new xml files and grow this list here? #3 - or, we'll keep the existing xml files as representative / legacy, and use them in the unit tests going forward, just to make sure the machinery builds correct descriptions? (I don't expect to answer to be #2, I just put it there for completeness.) > + }; > + > + for (auto &a : array) > + { > + auto tdesc = i386_linux_read_description (a.mask); > + > + selftests::record_xml_tdesc (a.xml_file_name, tdesc); > + } > +#endif /* GDB_SELF_TEST */ > } > Thanks, Pedro Alves