Re: [PATCH v2 00/12] FreeBSD/aarch64 hardware watchpoint support

[Luis Machado <luis.machado@arm.com>]

Hi John,

This breaks aarch64's build. fprintf_unfiltered doesn't exist anymore, 
and this patch is still using it.

On 3/16/22 20:19, John Baldwin wrote:
> Changes since V1:
> 
> - The unordered_map<>'s in x86-nat.c and aarch64-nat.c both now store
>    objects directly rather than pointers to objects.
> 
> - Trimmed "Contributed by" notices from new files.
> 
> - I have compiled and (very lightly) tested this on Linux Aarch64.
>    By light testing I mean that I ran a test program with a harware
>    breakpoint set on main and it stopped correctly.  I haven't run a
>    full test suite as my Aarch64 test box is a lowly Raspberry Pi
>    for which such a run would take a fairly long time.
> 
> I still have some open questions about Patch 6 from the first
> version:
> 
> Patch 6 has an open question about how best to handle having a
> platform-specific hook for when debug registers have been changed.
> Right now we require the platform to supply the function that
> nat/aarch64-hw-point.c calls.  I did not choose to create an
> equivalent to x86_dr_low, but perhaps that sort of structure, or at
> least a function pointer should be used instead?
> 
> There is also some messiness around the Linux-specific
> kernel_supports_any_contiguous_range workaround in patch 6.
> 
> OTOH, some of the FreeBSD/x86 cleanups in the first half of the series
> (such as adding x86-fbsd-nat.*) might be nice to reuse in my XSAVE
> series, so if that half of the series is ok (first 5 patches), it
> might be nice to push that in sooner.
> 
> John Baldwin (12):
>    Remove USE_SIGTRAP_SIGINFO condition for FreeBSD/x86 debug regs
>      support.
>    x86-nat: Use an unordered_map to store per-pid debug reg state.
>    x86-nat: Add x86_lookup_debug_reg_state.
>    Add an x86_fbsd_nat_target mixin class for FreeBSD x86 native targets.
>    fbsd-nat: Add a low_new_fork virtual method.
>    x86-fbsd-nat: Copy debug register state on fork.
>    nat: Split out platform-independent aarch64 debug register support.
>    aarch64: Add an aarch64_nat_target mixin class.
>    fbsd-nat: Add helper routine to fetch siginfo_t for a ptid.
>    fbsd-nat: Add a low_delete_thread virtual method.
>    fbsd-nat: Add a low_prepare_to_resume virtual method.
>    Add support for hardware breakpoints/watchpoints on FreeBSD/Aarch64.
> 
>   gdb/NEWS                         |   2 +
>   gdb/aarch64-fbsd-nat.c           | 260 ++++++++++++-
>   gdb/aarch64-linux-nat.c          | 352 +----------------
>   gdb/aarch64-nat.c                | 302 +++++++++++++++
>   gdb/aarch64-nat.h                | 109 ++++++
>   gdb/amd64-fbsd-nat.c             |  20 +-
>   gdb/configure.nat                |  12 +-
>   gdb/fbsd-nat.c                   |  28 +-
>   gdb/fbsd-nat.h                   |  18 +
>   gdb/i386-fbsd-nat.c              |  20 +-
>   gdb/nat/aarch64-hw-point.c       | 624 +++++++++++++++++++++++++++++++
>   gdb/nat/aarch64-hw-point.h       | 126 +++++++
>   gdb/nat/aarch64-linux-hw-point.c | 605 +-----------------------------
>   gdb/nat/aarch64-linux-hw-point.h | 105 +-----
>   gdb/nat/aarch64-linux.c          |   4 +-
>   gdb/x86-fbsd-nat.c               |  45 +++
>   gdb/x86-fbsd-nat.h               |  36 ++
>   gdb/x86-nat.c                    |  92 +----
>   gdb/x86-nat.h                    |   5 +
>   gdbserver/configure.srv          |   1 +
>   gdbserver/linux-aarch64-low.cc   |  13 +-
>   21 files changed, 1612 insertions(+), 1167 deletions(-)
>   create mode 100644 gdb/aarch64-nat.c
>   create mode 100644 gdb/aarch64-nat.h
>   create mode 100644 gdb/nat/aarch64-hw-point.c
>   create mode 100644 gdb/nat/aarch64-hw-point.h
>   create mode 100644 gdb/x86-fbsd-nat.c
>   create mode 100644 gdb/x86-fbsd-nat.h
>