Re: [PATCH][gdb] Update syscalls/{amd64,i386}-linux.xml

[Simon Marchi <simark@simark.ca>]

On 2022-05-09 06:39, Tom de Vries wrote:
> [ was: Re: [PATCH][gdb/tdep] Support catch syscall pipe2 for i386 ]
> 
> On 5/5/22 15:20, Simon Marchi wrote:
>> I suppose we are missing more syscalls than that, given that new
>> syscalls are added regularly, e.g. rseq:
>>
>>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d7822b1e24f2
>>
>> As long as rseq is not listed in this file, it means a user wouldn't be
>> able to use "catch syscall rseq", I suppose?  We would need a procedure
>> to add new syscalls periodically.
>>
> 
> I've wrote a script gdb/syscalls/update-linux.sh that can be used to do the update automatically.  The idea being that target maintainers can run the script on their platform and do the update.
> 
> AFAICT, the previous approach was to generate directly from kernel sources.  The benefit there is that you don't need access to a specific platform to do the update (but you'd still need access to test I suppose).
> 
> [ FWIW, it seems the linux kernel migrated to some syscall.tbl approach, and perhaps generating from there could be an option. ]
> 
> Anyway, this script at least adds one option to do the update.
> 
> WDYT?

One flake8 warning:

gen-header.py:9:1: F401 're' imported but unused

I would also suggest running shellcheck on the .sh script and
fix the issues, it gives generally good suggestions.

LGTM otherwise.

So, was this:

-  <syscall name="madvise1" number="220"/>
-  <syscall name="getdents64" number="221" groups="descriptor"/>
-  <syscall name="fcntl64" number="222" groups="descriptor"/>
+  <syscall name="getdents64" number="220" groups="descriptor"/>
+  <syscall name="fcntl64" number="221" groups="descriptor"/>

an existing mistake in our syscall list?

Simon