From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Add PR gdb/26967 KFAIL in two more test-cases
Date: Wed, 20 Mar 2024 10:15:59 +0100 [thread overview]
Message-ID: <cc8fa659-45b9-4112-beb7-6c71fa695c07@suse.de> (raw)
In-Reply-To: <87zfuugxio.fsf@tromey.com>
On 3/19/24 14:29, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> +set have_longjmp_probe 0
> Tom> +gdb_test_multiple "info probes stap libc ^longjmp$" "" {
> Tom> + -re -wrap "No probes matched\\." {
> Tom> + pass $gdb_test_name
> Tom> + }
> Tom> + -re -wrap "\r\nstap\[ \t\]+libc\[ \t\]+longjmp\[ \t\]+.*" {
> Tom> + pass $gdb_test_name
> Tom> + set have_longjmp_probe 1
> Tom> + }
> Tom> +}
>
> Rather than repeating this code, it's better to put it into a helper
> proc of some kind.
>
Ack, fixed in a v2 submitted here (
https://sourceware.org/pipermail/gdb-patches/2024-March/207377.html ).
Thanks,
- Tom
prev parent reply other threads:[~2024-03-20 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 7:44 Tom de Vries
2024-03-19 13:29 ` Tom Tromey
2024-03-20 9:15 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc8fa659-45b9-4112-beb7-6c71fa695c07@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).