From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F03BD3856262 for ; Tue, 19 Sep 2023 12:07:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F03BD3856262 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695125253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=icda8LerAygi6d+kcBqmEm8DaC2p9H4a2Esij6PwQ9o=; b=UYVcN0B8twpBi/m1vDeCj5PU4hzzqHVCkKCvekm7eu2h15UNRmXqEZyEcuSOhe2NLqda5q 8iy3hYDl1uDwVeOHK4+m06p8TL9JSGDIse8DRSUJhdApjZ/xy6voEA036VehbZo2RimlgT tayG0+jZw7zfMUguis9t0K7MqS4Xcp8= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-gLuTlLMgP9KXIgJX4cyNjg-1; Tue, 19 Sep 2023 08:07:31 -0400 X-MC-Unique: gLuTlLMgP9KXIgJX4cyNjg-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-94a355cf318so414671966b.2 for ; Tue, 19 Sep 2023 05:07:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695125249; x=1695730049; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=icda8LerAygi6d+kcBqmEm8DaC2p9H4a2Esij6PwQ9o=; b=WDiygv5wdEn2Enmi4PJyP8HX5txdOQDwsGiqX4gqOgjU9sE7Tj00IwNU7seocAyKCI E16pVuuNwN4tlIomdHzJnSLfCLXk307xSQOg/k69Js/wtvWDvq6Xn8DXG8eZvHdufKm7 JYj9skirekCkRKR07PAKN7FaXDbFP9ft4hC/LgRABvShbElRQEGk5IW+XLm/hnfWJPPf njRTpzgEayXvZ7WPysWVzWqVkEIvTrA04uVN6QHSFoL1w3LR1WTIBCnqOxB4K7Qv0e8J 9pce8D3s8EsR5cSIbMi3kWNvEnJIALKlCwr2dRLBWuuT7eQSBXI/JYFU/krPjcuLETc2 BrgQ== X-Gm-Message-State: AOJu0YxpvfCUDdx0+UZG7wcvldcuPl12khDw1d2qJ+louZJRQn+944a7 HKseAH849VOPDqaUuifznTvK9SP7zx9DZpkhEPdLAt9TaYHKr17Ukw5Hj23dOwbAw54EKyR3Ef6 Tf5fKsdEoCf4UXmqYmhkm3YxlZdFVeA== X-Received: by 2002:a17:907:a042:b0:9a9:f0f6:6d2e with SMTP id gz2-20020a170907a04200b009a9f0f66d2emr11323143ejc.7.1695125248954; Tue, 19 Sep 2023 05:07:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNaXxoNAlhxNzqdrJ6dVZABAFIVsMu4sDGHR9p7cYEP32eypfGjvI/nE5TTRnsj56XJNrliA== X-Received: by 2002:a17:907:a042:b0:9a9:f0f6:6d2e with SMTP id gz2-20020a170907a04200b009a9f0f66d2emr11323128ejc.7.1695125248656; Tue, 19 Sep 2023 05:07:28 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id gu18-20020a170906f29200b0099bc0daf3d7sm7634087ejb.182.2023.09.19.05.07.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Sep 2023 05:07:28 -0700 (PDT) Message-ID: Date: Tue, 19 Sep 2023 14:07:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4] gdb/cli: fixes to newly added "list ." command To: Eli Zaretskii Cc: gdb-patches@sourceware.org, aburgess@redhat.com References: <20230828155039.120251-2-blarsen@redhat.com> <20230919090627.2580364-2-blarsen@redhat.com> <83y1h2csi2.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <83y1h2csi2.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19/09/2023 13:27, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: eliz@gnu.org, >> Guinevere Larsen , >> Andrew Burgess >> Date: Tue, 19 Sep 2023 11:06:28 +0200 >> >> After the series that added this command was pushed, Pedro mentioned >> that the news description could easily be misinterpreted, as well as >> some code and test improvements that should be made. >> >> While fixing the test, I realized that code repetition wasn't >> happening as it should, so I took care of that too. > Thanks. >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 98ff00d5efc..2837c62b163 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -90,8 +90,9 @@ >> expression parser. >> >> * The 'list' command now accepts '.' as an argument, which tells GDB to >> - print the location where the inferior is stopped. If the inferior hasn't >> - started yet, the command will print around the main function. >> + print the location around the point of execution within the current frame. >> + If the inferior hasn't started yet, the command wil print around the >> + beginning of the 'main' function. ^^^ > Typo. > >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -9212,9 +9212,9 @@ Same as using with no arguments. >> Print lines just before the lines last printed. >> >> @item list . >> -Print the lines surrounding the location that is where the inferior >> -is stopped. If the inferior is not running, print around the main >> -function instead. >> +Print the lines surrounding the point of execution within the >> +currently selected frame. If the inferior is not running print lines >> +around the start of the main function instead. ^ > A comma is missing there. > > Reviewed-By: Eli Zaretskii > Thanks, pushed! -- Cheers, Guinevere Larsen She/Her/Hers