From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 115243858C56 for ; Thu, 4 Apr 2024 18:57:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 115243858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 115243858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712257082; cv=none; b=wstlOvJUN9hSC4IsYyEFkEHoEBlYKNGQBnReNW9sLNLG8jIyveeeSJZ6S3nk/yotseKXcVPB5YAkMJ+ilky+UFcLIRcb4c8W4uCCLEcfTVq32srA0OXDVQ9UOO8FvcJhj3cJmdnLQfEuh9gWA+LIqQXfQyqaExDnLC3gAEAEcOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712257082; c=relaxed/simple; bh=vAxvG9kGr9LqpGWjX97qmsB+SXf84Z64Mhqw08Mmg/o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vu8XLwY5Ez2aam5eVoRJMtfqTUmNi+pEzNPPVl2KqW0Yr2NGlvVWyT8QdUETw+Dup88nYVUdWrDihNCfINGju1DSBtY8SmE1tlkyEg8l9quHcLXJOiRrvcEmnSDk4A5kI3+ofZTbnWgxEBoTVg8h/FSIqOY8I6OnYBnWL+bmxmk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712257078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GPOf8Ulp7fxHJ4vvdco1ols2kiZb1dBxgXZcOxgAzMw=; b=hexUZnekx0VE8L2l9YaiRsZFvf49YrPlOdotVM0njhZQdmqgPnH9ZHTv6by2NJd0r6gIuT FbG2T5GF2tAsHknnnxBfdO14E9dYf0lD1T7d2OFNevg5n0v3qzdwkA0PtRWbmuVQpmfBJ+ P4bwdF2CiaT+O7o0ai4rPCBNzSlhnZc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-536-UYT7YTjsNMyvWc-O982jNQ-1; Thu, 04 Apr 2024 14:57:56 -0400 X-MC-Unique: UYT7YTjsNMyvWc-O982jNQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-698fbfa5815so11157866d6.1 for ; Thu, 04 Apr 2024 11:57:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712257076; x=1712861876; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GPOf8Ulp7fxHJ4vvdco1ols2kiZb1dBxgXZcOxgAzMw=; b=Dd/6RF4BW2lUjwh4rzCnvBZty8M4gMzoVm2tQ1Tik+a59VXhzklGI3aag4PQ/wGAJS tbynFq7Pjvkbf2LngRk3SU6VTUZVuKggb22U/Vwn6fvaFr8gI8m1VF0AE/k7vWtwsBKn NkHp6QGTe3a85UZsGtzXhQM8dPworZxHLhIskvNOh5GtsaXSyEpcdHMZReAVB/8W0WqO DGt12yYjAtVWfv8zkgA1kFc3m5zHAlTqsxD/f4Y9Uj3Wf9r1Fm50HAqN6M3DBTMQLZ/6 fHhqkTiiyGI5WZsDF4FSratkwB1ej7x6zm9yOJnoCju9+eMkkK8Op6gCSfGHqqlM+LXQ VLlA== X-Forwarded-Encrypted: i=1; AJvYcCUuajGlAVZqWvlsCJvYYP0qp9Q4SJkMwgsMsUO7Ny/MsPmfo42ccTtAhID6J40GBD0Zuhgmzbufw1dwL3ASHYbjnXr1HQXfjBJhww== X-Gm-Message-State: AOJu0Yw0SHYDp9RXi4o8FE2gNvAzVCNH0o3nnY+N4evy6vJrXb0ElEIU oQR1SNuAOUZMGkAeZYylMxTrsdC5D/ztdp06fFLnXIlyK1OgF6mDu7ogFS+VwqszrxSnfoo9k4s zS8k3S3ibG15VwONLYCTyFerbCnukGSaGoD/VbdQyMRyrbSkZRAZo021cKzN7mueR6xa+bg== X-Received: by 2002:a05:6214:1bc7:b0:699:230b:232f with SMTP id m7-20020a0562141bc700b00699230b232fmr632842qvc.48.1712257075491; Thu, 04 Apr 2024 11:57:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGC8gBVxY7bNcB7Wv6SJhp28KwkRahL+a3DAY/880IR3KAuNWvq4p/+AXiIYMSYLUIEB179oA== X-Received: by 2002:a05:6214:1bc7:b0:699:230b:232f with SMTP id m7-20020a0562141bc700b00699230b232fmr632833qvc.48.1712257075222; Thu, 04 Apr 2024 11:57:55 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id a1-20020a0562140c2100b00696804c73c5sm7707671qvd.115.2024.04.04.11.57.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 11:57:54 -0700 (PDT) Message-ID: Date: Thu, 4 Apr 2024 15:57:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] gdb, infrun, record: move no-history notification into normal_stop To: Markus Metzger , gdb-patches@sourceware.org References: <20240312113423.3543956-1-markus.t.metzger@intel.com> <20240312113423.3543956-4-markus.t.metzger@intel.com> From: Guinevere Larsen In-Reply-To: <20240312113423.3543956-4-markus.t.metzger@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/12/24 08:34, Markus Metzger wrote: > Leave calling gdb::observers::no_history.notify to normal_stop based on > the last waitstatus. I don't have a problem with this, but I don't really understand why it is needed. Do you see any thing that is an actual problem right now, or this is just cleanup? > --- > gdb/infrun.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gdb/infrun.c b/gdb/infrun.c > index eb5164b4066..f92f529412f 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -6538,8 +6538,6 @@ handle_inferior_event (struct execution_control_state *ecs) > if (handle_stop_requested (ecs)) > return; > > - interps_notify_no_history (); > - > /* Cancel an in-flight step-over. It will not succeed since we > won't be able to step at the end of the execution history. */ > { > @@ -9002,7 +9000,6 @@ keep_going_pass_signal (struct execution_control_state *ecs) > if (ecs->event_thread->control.is_replaying > && !target_record_is_replaying (ecs->event_thread->ptid)) > { > - interps_notify_no_history (); > ecs->ws.set_no_history (); > set_last_target_status (ecs->target, ecs->ptid, ecs->ws); > stop_print_frame = true; > @@ -9642,6 +9639,9 @@ normal_stop () > if (saved_context.changed ()) > return true; > > + if (last.kind () == TARGET_WAITKIND_NO_HISTORY) > + interps_notify_no_history (); > + > /* Notify observers about the stop. This is where the interpreters > print the stop event. */ > notify_normal_stop ((inferior_ptid != null_ptid