From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 89C513858408 for ; Fri, 2 Dec 2022 14:34:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89C513858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B95BE1E112; Fri, 2 Dec 2022 09:34:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1669991645; bh=CBIEvthXvf28VSyxJPSkCLkn//d9X5BnmsM9mLcave4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=DV8xQYgb/jOlzHAo9J38J4d/07tzXobYOXzQDSaeYijzNZPpxJrmHt8uT3nEf3fQN KwcjmR0CIXZSGen15gChRQEWmE4eyfCEfi+pSnM7DFD04jth+N7ETbfEvtVBNcWI9W u8z/k0s8PC18j9OhTrXOmyFxiqJw7gZJ/HH89+2g= Message-ID: Date: Fri, 2 Dec 2022 09:34:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/2] gdbarch.py: Fix indentation in the generated gdbarch_dump function To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20221201223914.366184-1-thiago.bauermann@linaro.org> <20221201223914.366184-2-thiago.bauermann@linaro.org> Content-Language: en-US From: Simon Marchi In-Reply-To: <20221201223914.366184-2-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/1/22 17:39, Thiago Jung Bauermann via Gdb-patches wrote: > Use tab for the first eight spaces of indentation, and align the gdb_printf > arguments to the open parenthesis of the function call. LGTM, but please run black as documented here to re-format the .py file: https://sourceware.org/gdb/wiki/Internals%20GDB-Python-Coding-Standards After that: Approved-By: Simon Marchi Simon