From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 465D33858D35 for ; Tue, 23 Apr 2024 03:18:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 465D33858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 465D33858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713842340; cv=none; b=K2FSaYyAiSFMDDJ9d7fHxrwT/hzI6huEtdsdBmSeWrsCUOAORNPsP4MyrveI9nU6q4QmsU83aKZ6yKXa3v7tXdE6F4sINwHisjgg2yNkhjrjEGn++/KabuvYaBpqMMZ2PwlAH1d5u3l+pX9jUhfNWQ6sQ3dmz+rD/rJh4lDlz3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713842340; c=relaxed/simple; bh=BBw95OROkIuk/j5L5lG3kHU8qKNqyA62vmGN189pccA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Gvt+NqiqP9HYEDvDbw68u0YWa7EZ1vZiibAt6lBLj1g2QCIFqnVUzRjWRoke2Zt3SdZ8o/pz0YgWQeGPhDaVpQ/2aJTmNgxVLpiMhvnFGEI1FcrnT65P06V7684tGqzwgx6YHEmkNBZS9Kmphhh0Lz59Le/7XtNNjlBpBfKSV58= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 43N3Ir7J060463 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Apr 2024 23:18:57 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 43N3Ir7J060463 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1713842338; bh=fgQmkhnwBEq8Avq03Grl2fnGiuc1cdwZ0HSkq+mqcx4=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=e8aMxqw+P9RgdhuLr0P7lkShXn9SzyI4ul6e941Upxuq192Ttjz+o3tF0ycjBFftV F4pmy7Ojql6oClIPLLGUtw9V8Ei6PXfyybjpINbaYdFZfrrOxV147LdIvgijysnTCz tnClBURH9PdjFDtmRViW4nv4sTkZ+E2eRWtzD4kM= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B73C71E0AC; Mon, 22 Apr 2024 23:18:52 -0400 (EDT) Message-ID: Date: Mon, 22 Apr 2024 23:18:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pushed] gdb: fix include for gdb_signal in target/waitstatus.h To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240419200856.2291305-1-simon.marchi@polymtl.ca> <87h6fxt86u.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87h6fxt86u.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 23 Apr 2024 03:18:53 +0000 X-Spam-Status: No, score=-3037.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-19 16:21, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> diff --git a/gdb/target/waitstatus.h b/gdb/target/waitstatus.h > Simon> index dce1a7f3175e..7d5ad3f97769 100644 > Simon> --- a/gdb/target/waitstatus.h > Simon> +++ b/gdb/target/waitstatus.h > Simon> @@ -21,7 +21,7 @@ > Simon> #define TARGET_WAITSTATUS_H > > Simon> #include "diagnostics.h" > Simon> -#include "gdbsupport/gdb_signals.h" > Simon> +#include "gdb/signals.h" > > I think target/ files should not depend on files from gdb, because > gdb/target (and gdb/nat) are also used by gdbserver. This is include/gdb/signals.h, not a header from the gdb directory. > IMO that's a confusing situation and we should probably move those > subdirs to gdbsupport (but not build them there) to make the setup more > clear. If that's possible. Agreed, I don't really like the current situation. Simon