From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84016 invoked by alias); 11 Jun 2018 00:28:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84003 invoked by uid 89); 11 Jun 2018 00:28:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=opportunity X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Jun 2018 00:28:50 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5B0ShCU015052 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 10 Jun 2018 20:28:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 814131EF28; Sun, 10 Jun 2018 20:28:43 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 245CF1E02D; Sun, 10 Jun 2018 20:28:43 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Jun 2018 00:28:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Remove a VEC from record-full.c In-Reply-To: <87in6qch4e.fsf@tromey.com> References: <20180608025636.14640-1-tom@tromey.com> <87o9gi7hyp.fsf@tromey.com> <1b1a05c47192dd4dde60bcf3f58d229a@polymtl.ca> <87muw2clw8.fsf@tromey.com> <87in6qch4e.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 11 Jun 2018 00:28:43 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00264.txt.bz2 On 2018-06-10 20:16, Tom Tromey wrote: > Simon> Maybe I'm missing something, but it seems like the > Simon> record_full_breakpoint objects are never freed. That's not > related to > Simon> your patch though, so your patch LGTM. > > Tom> Thanks for noticing this. I think this is a good opportunity to > fix the > Tom> problem, so I'll take a look at that. > > How about this? > > Tom Thanks, LGTM. You can get extra credits if you make the in_target_beneath field a bool :). Simon