From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2066.outbound.protection.outlook.com [40.107.6.66]) by sourceware.org (Postfix) with ESMTPS id 60D403858C53 for ; Thu, 19 Jan 2023 12:47:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 60D403858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JVE3kKoA2O59sk3JKosDl89fO9YL18s7oFow8H+Bsqk=; b=2eezqPdHwLVuBS7QzcZ0/YMW9/cBRYcSaFsNuT/dI5A8U6yhNIUmhpWmjMcSSBBQznoBKb8Moa2dRCSEHoiYSZvmF/F5tKIAZD5hDaZO3zsdK+9y1UwidTzD1oo0XQFAlav2kAY7Oq9Qtk0OwS3bN2DXLSqBoqZsQZ/OAAF8qQw= Received: from DU2PR04CA0040.eurprd04.prod.outlook.com (2603:10a6:10:234::15) by PA4PR08MB7642.eurprd08.prod.outlook.com (2603:10a6:102:260::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 19 Jan 2023 12:47:18 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::5c) by DU2PR04CA0040.outlook.office365.com (2603:10a6:10:234::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.25 via Frontend Transport; Thu, 19 Jan 2023 12:47:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.16 via Frontend Transport; Thu, 19 Jan 2023 12:47:18 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Thu, 19 Jan 2023 12:47:18 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 84726ddbe21bb246 X-CR-MTA-TID: 64aa7808 Received: from 88073f9e516b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B5E29F80-34C3-4D29-904A-D728029B626F.1; Thu, 19 Jan 2023 12:47:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 88073f9e516b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 19 Jan 2023 12:47:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VN4J7zipDaXT2tfsFof6EMIfCAh7h7htvDvg9BJ+ODD7Vad86mZ14402hskbH/jS5/kYAB69qpCd4v96bYHQPyYq1MZH3M+Aney80SfSPpDlnwNTM0hWQIwd4IrYHWSIEBwL8P2LbPTPzjMcS/Hazu1+ZbWn6oSKjVOvDW03VgJ09sVmcsUWHXUHPKesb1oF83Wm8V6OOWAFxkMLg6dUnAv1Are86w+U1Rn/9noyqX7hmO9urj4lC86UZYmEfWlyLCva5t3itqj4qlBST0s8A4ZosLCAkCtSlOkFNyvERMBirWOlRSOKIQzYwSwsbGoV6GmjLWkbRhZqae5tjJLMaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JVE3kKoA2O59sk3JKosDl89fO9YL18s7oFow8H+Bsqk=; b=N3tl7vKDFV6XPWjoqXrKOHJNu/oj7B1KYIeQ2S+JEl/vfoBOMDnyJHU6rQSrJ634xDRhiAUdjzydDpnoJKZ0uQmKmi886rw+9rRNyvCvMDsKZ+wqkkn1da39+ECHV0gc01rQKys7CI62Y2g4y7hR9QCZrLPYCn2AAwuXRLT5XcNc9YQY6y0VMwop3zf5tSnvTIWEejOVZpGnFwWC+1Rh0u9ZfeyYeVtI/QpFaw/RZ0vxfPzo7wn9dyUDMLi8ionq9sEUUqmH52Qqc1PxJbl7qYSDUZZ9MjT0q3vkKYRfKuTuOhXUmr7SCfo3x/F8IUi/FrvUbsRRT94VE2m2yQkRSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JVE3kKoA2O59sk3JKosDl89fO9YL18s7oFow8H+Bsqk=; b=2eezqPdHwLVuBS7QzcZ0/YMW9/cBRYcSaFsNuT/dI5A8U6yhNIUmhpWmjMcSSBBQznoBKb8Moa2dRCSEHoiYSZvmF/F5tKIAZD5hDaZO3zsdK+9y1UwidTzD1oo0XQFAlav2kAY7Oq9Qtk0OwS3bN2DXLSqBoqZsQZ/OAAF8qQw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DU0PR08MB9464.eurprd08.prod.outlook.com (2603:10a6:10:42c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.25; Thu, 19 Jan 2023 12:47:05 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a%6]) with mapi id 15.20.5986.023; Thu, 19 Jan 2023 12:47:05 +0000 Message-ID: Date: Thu, 19 Jan 2023 12:47:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] [gdb/tdep, aarch64] Remove fp and sp reg aliases, add x31 reg alias Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20230119123744.18276-1-tdevries@suse.de> From: Luis Machado In-Reply-To: <20230119123744.18276-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0199.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::6) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DU0PR08MB9464:EE_|DBAEUR03FT051:EE_|PA4PR08MB7642:EE_ X-MS-Office365-Filtering-Correlation-Id: b5abc2f4-a6d3-436e-1495-08dafa1b4cf3 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cKWWDk+kszOsGEAhP0LiR3M6hLvgAuacqkf8LZJbSHAxQViRJKZ5wljs05ItulpgL1aU7Wu/YGKA4bIsn7wyJbwhUKzt81gX6CvHfA9C98I2EIKrKTjONIL0MZe+YciIi/papqovB/9ILb369TJdMLfGsct+FlCQoIjLJfiVMFsZuVnLBrt7kQmarls/G6+VTGByLaN1z9aodFzZS/2yA82/GgTe0OOyD9Ugw/kDPJ9+WT7tfdb8I5g3+F6Oh2bfd7vq/IMY4FnvxNBfTuVgYL3Abdfti7bGlQsQ2GJHwIGD8imfbDqsvRt7bO4qxSEh3708Xq3CoQxcsqKUOwSJt27zIXA5ohbnb1pVTqOwNNDLHDAnHsYj/aAQVz69tqQPgv0j1GGR9MEBm/p1WfC1NmeDK8LzVbrMjpUo9SOYZGaCrWxYLCkWmfOItwENgovFvKdsAqziCLjPGxniAPSSIx7VasuFDekPIL6SO6KGNowyPxH1DLP1p5MSUCsrz+/bhkp7FU/p9Lz6DQBiP6xsg0AR4BxUeFoe+Skr3lvb9xSvFqrZonEmR9j7xW5E0kYi9doj4OXntBuWsY/Us3Rx7PDs9gdAWJSzi8mhhXKTZfZvF46wKbQg9xsM19QEnv2kRGXjIfGEUB2FofCnfkyaJd8+W1O6aQg2wKMfa7/KEBoOhy0ttglGYn3Op/+Fbk2vfU2N9MV2ke/0aXgQGxupPTmNO/DoLTZjFNgrSzXirNqIvTljANwpZSiK7/Mdx6l9 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199015)(66946007)(41300700001)(66556008)(31686004)(66476007)(8936002)(44832011)(316002)(36756003)(2616005)(2906002)(5660300002)(8676002)(31696002)(86362001)(966005)(6486002)(478600001)(186003)(26005)(6512007)(53546011)(6506007)(83380400001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9464 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e74bcd80-e826-4620-88ae-08dafa1b4498 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CYf9QTYwJskpAxCLrAl99NU7RsaT7vjXdZ6pOrtx5HTWq/g1caMkTO8eiYVujuhJ4jtuDDTxSxTmwJT0pRy0bW3tnZ918CpOqB5g6bUBfTXnlSniDx710TLfvTx04CmdogLVwTSVQQzprT3r4gHN2N3ZnhAN7vjyefHpVWtnhARQeDxGRezB57kcLqDUAiaqBk3VUkf9HSAKsyOSFHoFmbbKS44pkuleT0ZOZmSHmXcOvpZjiaohB/IWcL3mNF3XB7N5DP7aC+Y06xkqUsvlwTGFIGXUcIoZK1LjbpqSqLKDRZXW6Uzo+F/Z824vb+kGiEGVRwXCcn4Lwp+1FRYp5LSeBRyz6lOSr5vRJtaimLFcun0PwVFJDp476z1QQ13Szkc8UroHtLCzff+LtUjiD3y8m5JEQeVtLDsPBCT5OaVPEynGOV6RbrwrtKwpXKeLkySz0PRfFqsEuFoaAVilCzXYNxYBDqPB00tRBSvwdsYpNdUx6ri/RuKgCV1cWQOc4qx1v+l+LL7z8t/mNewY9REj7FYz5paX1DmVpgxsQkYmpIL3LYEr6Xn/IwCYG7RpTqRzQAX1bckC2RZXNm3mqpHF5iTGVRGPGYC2oIS59LMPmW3tVzterQ6w/MuVj4Yk+EtL2K5fAC3iTZ/0XCy3Ie3MGAXunPQs5F2cJEYRrxGCjHhh2gmzgyexube9q6WdqwZXsYhbMw9tCQqH2mz/XAdhXDRNfj+LtG9jzAxf12ZNLMZyJEmy+vRzgN2U9/5GwrHaSSnrvBosjWPl7RMAhw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199015)(46966006)(36840700001)(40470700004)(2906002)(31686004)(8936002)(36860700001)(53546011)(5660300002)(26005)(44832011)(186003)(41300700001)(31696002)(40460700003)(6512007)(36756003)(6506007)(8676002)(86362001)(356005)(70206006)(40480700001)(70586007)(81166007)(2616005)(336012)(47076005)(966005)(6486002)(82740400003)(83380400001)(316002)(82310400005)(478600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 12:47:18.8250 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5abc2f4-a6d3-436e-1495-08dafa1b4cf3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7642 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, Thanks for addressing this. On 1/19/23 12:37, Tom de Vries wrote: > From: Tom de Vries > > In aarch64-tdep.c we find these register aliases: > ... > { > /* 64-bit register names. */ > {"fp", AARCH64_FP_REGNUM}, > {"lr", AARCH64_LR_REGNUM}, > {"sp", AARCH64_SP_REGNUM}, > ... > > The sp alias is superfluous, because the canonical name of x31 is already sp. > > The fp alias is superfluous, because it's already taken by the default meaning > of fp, assigned here in _initialize_frame_reg: > ... > user_reg_add_builtin ("fp", value_of_builtin_frame_fp_reg, NULL); > ... > > Fix this by removing the fp and sp aliases. > > While we're at it, add an x31 alias for sp. > > Tested on aarch64-linux. > > PR tdep/30012 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30012 > --- > gdb/aarch64-tdep.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index b576d3b9d99..1dcedac31f2 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -61,17 +61,20 @@ > /* All possible aarch64 target descriptors. */ > static std::unordered_map tdesc_aarch64_map; > > -/* The standard register names, and all the valid aliases for them. */ > +/* The standard register names, and all the valid aliases for them. > + We're not adding fp here, that name is already taken, see > + _initialize_frame_reg. */ > static const struct > { > const char *const name; > int regnum; > } aarch64_register_aliases[] = > { > - /* 64-bit register names. */ > - {"fp", AARCH64_FP_REGNUM}, > + /* Link register alias for x30. */ > {"lr", AARCH64_LR_REGNUM}, > - {"sp", AARCH64_SP_REGNUM}, > + /* Sp is the canonical name for x31 according to aarch64_r_register_names, Sp -> SP, in the comment. Otherwise this looks good to me. Thanks! Approved-by: Luis Machado > + so we're adding an x31 alias for sp. */ > + {"x31", AARCH64_SP_REGNUM}, > /* specials */ > {"ip0", AARCH64_X0_REGNUM + 16}, > {"ip1", AARCH64_X0_REGNUM + 17} > > base-commit: 75c2efc6f19fe454413aa70d2c37e543f04a67e1