From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by sourceware.org (Postfix) with ESMTPS id 315F0385840D for ; Wed, 24 Apr 2024 19:40:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 315F0385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 315F0385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713987655; cv=none; b=RONixMv1vFC0Dn9UzchMkXZIJ3nEq7aO5NONOOUrmd+dhsDISNd1ommxmYgFiUZOzpoCb6m4aFyTqjXKqPeOz+7rpRH/QX6ZJEZxDDxT962JXugXmpP6i2NKfo/MoP2BA1c6cdXDVhC0BUYsoCGrnqnEm9/1RerZG4G2FxKJtuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713987655; c=relaxed/simple; bh=MD0wDey7roO8esMOpCn3i9XaQAPckf7psdRrapte2oY=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=IfQ7SoTseioTCwoJKqQshpzskjyDt1U2fYR6Sf1vv2wwC4o04vBwqEwzYpocKhGX/Awio4QxJtMqO0jNJFDEdvCo8KhICVeRVb2KskUr5y6QNM0CKT69plGqZjL1RuqkY4Uv/gbaUPpa1+GvD5xsws8ksPGeIy8GBEJHhzhEZn0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-41ac4cd7a1cso1740295e9.1 for ; Wed, 24 Apr 2024 12:40:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713987653; x=1714592453; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hnL8N71D7CRbcoSM4Kb4DWkDod4KZm9yS0cD9w0DOrQ=; b=NxBettkPGRCcOPNoh9qnKujwiWcfChTUQlZIlkBKur2l/bxEQKQ45CHqknx+sK05Sl 3x76aOSaoC8o4I/fZV9w0B25rpimcZ2nfNhid/0E40Xsyz/IfJ+6mecC5C/8kIm98t6Q u8jqt7iTTZ43dB3Ig+YvwIuw9zNdnw5jKCcabgUGhJiZ7OTrDcsbrRyBIFPBHDHO9dlH vDC7Dy7elsWhoRZJkfJ5TaqWXLYPOTdwk+mBPkBJMjdwJiSrz15Ly9duKavGDAESHIHK 9OAMoxeoyD/xEEC1IzEgPfokuY2ukileof0voWyMxLRvT8ZziIXBfHDtNW3MkAIGRVqb N4TA== X-Forwarded-Encrypted: i=1; AJvYcCVz5b31BKTTWqGgtgLjUp6/dZye+jkNpTzKJ+spfSoAHGolWdi0/6R7CH1la00sDYdvha8V9s5D+bX0CuLb9M95PkOE3UKN/5E/XQ== X-Gm-Message-State: AOJu0Yw1ToRys7ESUgHVWsGzstMowvULr4wEyMGqCbmIL35Vr/kZ7V8J tQ626rw6bnDLJfTC3eVT1rdxq5CY/4kpjsfyqv0K1DohZLxo6XNb X-Google-Smtp-Source: AGHT+IEXUwz7uDf/PGUpiPC0HLTaGbvGApT1mu32qpUkbEmqXrY2HbQvBd4kMSjY+AX6Y/e/nlId1w== X-Received: by 2002:a05:600c:5114:b0:41a:34c3:2297 with SMTP id o20-20020a05600c511400b0041a34c32297mr2393120wms.5.1713987652563; Wed, 24 Apr 2024 12:40:52 -0700 (PDT) Received: from ?IPV6:2001:8a0:f93d:b900:e6fb:f181:abd6:74dc? ([2001:8a0:f93d:b900:e6fb:f181:abd6:74dc]) by smtp.gmail.com with ESMTPSA id q6-20020a05600c46c600b0041892857924sm24902081wmo.36.2024.04.24.12.40.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 12:40:52 -0700 (PDT) Message-ID: Date: Wed, 24 Apr 2024 20:40:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/testsuite] Handle ptrace operation not permitted in can_spawn_for_attach To: Tom de Vries , gdb-patches@sourceware.org References: <20240418063237.1545-1-tdevries@suse.de> From: Pedro Alves Content-Language: en-US In-Reply-To: <20240418063237.1545-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-18 07:32, Tom de Vries wrote: > When running the testsuite on a system with kernel.yama.ptrace_scope set to 1, > we run into attach failures. > > Fix this by recognizing "ptrace: Operation not permitted" in > can_spawn_for_attach. > > Tested on aarch64-linux. I really don't like relying on "attach" 's behavior to decide whether to test attach. It's an inversion of responsibilities. can_spawn_for_attach means "can I spawn a process, such that I will attach to it later", a simple atomic thing. Also, with this change, it means, "can I spawn a process and does attaching to it work?" So it ends up misnamed. Someone tried to add something very much like this a while ago, and I objected then: https://inbox.sourceware.org/gdb-patches/e5f08136-fa4d-2f21-ff83-8adf4d3a158e@palves.net/ We ended up with gdb_attach, added in a7e6a19e87f3, which handles the "ptrace: Operation not permitted" scenarios too. Some testcases have meanwhile been converted to use gdb_attach, but there are more, of course. IMO we should continue that direction. gdb_attach is not unlike "gdb_run_cmd" for example. See also: https://inbox.sourceware.org/gdb-patches/3b845985-cbd4-4996-145e-14191338b095@polymtl.ca/ Pedro Alves