From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DC8BA3858CDA for ; Tue, 8 Nov 2022 21:20:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC8BA3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667942400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eWiEY2VM//edqYehaRc0LD9ehA8tm6tlaamJ09Pt75E=; b=P8XIGGgYDrgJ9kGT03X5LIs8EefkG0OrNrxTMgi6sjiF5f7bZIVz5Gy5N8RWVE6af8FuhZ mOxQE+VUbaoG9uoUAaz27TQARmrYqU2qroXWYPm/6lLH//JUEUAOTUl5Se+qcAjx33ku2x B0flSvPkSotUmesu80ajYQUGQl83gJ8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-392-x0OwnW1YPL2PYnAj4OWAWg-1; Tue, 08 Nov 2022 16:19:59 -0500 X-MC-Unique: x0OwnW1YPL2PYnAj4OWAWg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 069C42A2AD78; Tue, 8 Nov 2022 21:19:59 +0000 (UTC) Received: from [10.2.16.23] (unknown [10.2.16.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7DDE40C2140; Tue, 8 Nov 2022 21:19:58 +0000 (UTC) Message-ID: Date: Tue, 8 Nov 2022 13:19:57 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] Allow 'ptype/o' for assembly To: Tom Tromey , gdb-patches@sourceware.org References: <20221108201452.1255047-1-tromey@adacore.com> From: Keith Seitz In-Reply-To: <20221108201452.1255047-1-tromey@adacore.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/8/22 12:14, Tom Tromey via Gdb-patches wrote: > PR exp/28359 points out that 'ptype/o' does not work when the current > language is "asm". > I hesitate to bring this up, but... Why would the current language matter in this case? [I understand that the print options are set before the expression is evaluated...] Since we have the type of the symbol, couldn't we simply use that? Maybe it's not worth being so pedantic? In any case, it LGTM. I recommend you approve your patch. Keith