From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68810 invoked by alias); 30 Apr 2018 13:34:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68799 invoked by uid 89); 30 Apr 2018 13:34:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=largely, Hx-languages-length:592, his, nature X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Apr 2018 13:34:24 +0000 Received: by mail-wm0-f44.google.com with SMTP id a8so13212583wmg.5 for ; Mon, 30 Apr 2018 06:34:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XmWGoHxU0llI+5CfOb7yVLOexE6G3nFuVQB5h/jlXO8=; b=rOIw7Yw14gp8C1qhssgy2d3AV55CjmjIQj/Cc7DOdwIetIP7bAWEKgIBmb0+XwdZD1 0REyDJ1NDir1iQtaXtaZ5YYQShlFMuRUKE5j+TFl8Kg7hJ7Q/C9pBKjJvGb7AaYfKa3c HiFY3xpM+MF525j0ZY3jqCd/OOQlhBTAs60GQ6Cm/suCiUn2S3pLyIl0+kijPVW6Lwj2 3m4sOiarBv+buMve0FAqd9r1/HHqDWQqwoCxxKIWPZ1A9Mx1NG28V+iJXI1CPVJ188Te O2jHPDUTUqUoU0IPDjElRM22GEl/jfHk1kOQFvu9hKCU2MTwzI0ugxqwj6IUTD6Vx2QM dwDQ== X-Gm-Message-State: ALQs6tAysmqJG2FXhTmI44jakDa6TkmPDKpOd/s0YWNp9dd3n1vrLGC6 +3hOx1HDFC8LJH8dhoZXQ9Gc+WKOhzw= X-Google-Smtp-Source: AB8JxZqugv6d4OliALlLXQtB0VWmHDmjTSUTBZREE5QBghyfuZFBSwlSpui2k8RwCD1Bdis7bNlLsg== X-Received: by 10.28.247.20 with SMTP id v20mr8124168wmh.73.1525095262192; Mon, 30 Apr 2018 06:34:22 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4? ([2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id z63-v6sm9412342wrb.34.2018.04.30.06.34.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Apr 2018 06:34:21 -0700 (PDT) Subject: Re: [RFA 4/4] Change Python code to use new_reference To: Tom Tromey , gdb-patches@sourceware.org References: <20180430042147.28337-1-tom@tromey.com> <20180430042147.28337-5-tom@tromey.com> From: Phil Muldoon Message-ID: Date: Mon, 30 Apr 2018 13:34:00 -0000 MIME-Version: 1.0 In-Reply-To: <20180430042147.28337-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00622.txt.bz2 On 30/04/18 05:21, Tom Tromey wrote: > his changes a few spots in the Python code to use new_reference > rather than the manual incref+constructor that was previously being > done. > > 2018-04-29 Tom Tromey > > * varobj.c (varobj_set_visualizer): Use new_reference. > * python/python.c (gdbpy_decode_line): Use new_reference. > * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use > new_reference. > --- The Python related changes are largely mechanical in nature but just wanted to note LGTM. Cheers Phil