From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2073.outbound.protection.outlook.com [40.107.115.73]) by sourceware.org (Postfix) with ESMTPS id 61C463858C50 for ; Tue, 12 Sep 2023 17:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 61C463858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ikh5xDp0Ug6vUMxpPbp+dYg33mhg+IRNXsvDB7+4pWqD4o3++2+6YmW5z6hE0EjN0dVUnzC5gHtQQZGZPQPHxO1OxfoUJszrWtCO+bE0sq3hRQnegR1ecKfpNI5CNfy4kecLZBY/p0lgofH2o4by6VKdIbiMp109K0LGf0cJX4wdpTR1b5I1zhlaVZKDxZ4nnsblnWefR6OizlJKs4+FNUF8WJdoe7QvgS5zK/Rj7Q4DNvwoPS0QM1juLZPOVYvItJnCh/PtTO412MckuxmRRlaEuDyqj60F9dF5YV6dzvTG9fk0XPCss50SBa4cWye6Y9OyywNPnhOvX0SzxTMXdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+KhsSiknoRvG11EwoHJrFjiF2vmjVd46/EusB6/uLiY=; b=IRvx/ZLpcJar0EWamwk6Zcdfq3HzZPrR7047a6KAoqn6pigXd1s8Kxwr5/IpStPJE8g/mVVKqWmd4u+aV3I3OBYRyEMvvw7kPGhRSbme3jz2HTHHA2mK+zUjbGqrfTQTyf0U3o+berI+IkcxmRIP9sm5n4c+d/Bt4x+o3HUQzPb/VF/Fz/f0luG0XNHIuG8nL9MxQZgJc00MHW92u7qzFIi5CeJBQ7UqVPx04Ti89CC9LKxJumGjoc7NbrTjYaKleqJP6UnBKyMKJ1R2rleg2bgSvyBCAg84lpBb0bhBfIqq+43f8yfkbCU7JxR3NCsDM96iNxdtbOwm2oi7U5E1kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+KhsSiknoRvG11EwoHJrFjiF2vmjVd46/EusB6/uLiY=; b=FKLfmDfS+PKjs8AbXA1d9uPB0ISb48ARqbX+h+IWJMAkcTWWttygpMZqmbxQWLpxOSRDxQM6LASY/G5WPMloZblhV28T/f8UrKSq84kCoxEDHdM3F1Yhsfk/KlyX7wuCE+mT7sYu4scwtTGRL6y8yOx0aRWy69SIQJgvSHeHzYERyQElNCjj02js9JGWiLETy00IH2SWKDjYXQLMQMvDuY4WgXip+xTxy8f+bgBCHQm9263eLpx0HSO9RLoq/EmJblgksCV9GyvKpByWAhPARFY+gipdLtzxf325S574M5spTaj5sRkQXcWPn7LB9p1Js8e1QWH8z0wa5lFGYiij9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT1PR01MB8396.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:c4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.37; Tue, 12 Sep 2023 17:23:17 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::a015:84e9:f0da:66ec]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::a015:84e9:f0da:66ec%4]) with mapi id 15.20.6768.036; Tue, 12 Sep 2023 17:23:17 +0000 Message-ID: Date: Tue, 12 Sep 2023 13:23:15 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/21] gdb: make interp_set a method of struct ui Content-Language: fr To: Andrew Burgess , Simon Marchi via Gdb-patches References: <20230908190227.96319-1-simon.marchi@efficios.com> <20230908190227.96319-19-simon.marchi@efficios.com> <875y4fk68r.fsf@redhat.com> From: Simon Marchi In-Reply-To: <875y4fk68r.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQXP288CA0016.CANP288.PROD.OUTLOOK.COM (2603:10b6:c00:41::44) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT1PR01MB8396:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f342476-0e60-4c2d-afc9-08dbb3b4f3ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AiZO17RxrVbpgBgqRxvQKPh3ancfPFATx8RjL0k9GjTAyt9FxUq8toyeptBYU6yZxC1XvNqwpoLVmXC5l/r7HG6HU+/GxRVtCjUpZEtGSLbhReH3SX3ZI7vzetQc5J8BMFk2CMx6l/70YGdUXlUlrg/pagAgnTxgKcu8yoRy39is88rYl8X7rlLo53HnVlCLh0cZV+HpmYbPu6beUqGEOO8TAGDuiXH8tzPJbxj1qHSws6f3slsrTADGuQ6UJfVa/hCSekBlGMEEjofVn3lfX+b/BfF52N5Z5R6R8h+SaGIQfU2N3sgB34Im1jVHORlu6YCzmKrtHjgroWN/TkytmNZZ9sCUiuRIo5zX6eyZe1bhZThKwmxbhYtNN+6S9QikSep5bx7zLxgWZPqx/Oc8LESGqciNhBEtoKM4Uc2ik/vAZWqospsAMV46IlNFl/BgAHqmYMsmZwhLKZcoU0TtzNFuA9wVmQSw2kzUq61J7sCUy6Y/cYGEZjQyeF9WXzZgtDx1K6VbECMJrPq0MaLoQA7fIrJf9FhI2hUoVs9BhB9UXCyGPbY9d/I1q4EYMPt9j4okvYUTwRo9koM5/+NbEEKLyUIXX26IbnBGLxgyNTih6hffpyIAk6IxYMU+hqHi/K2wBxorN3TPwofqcKnPTg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(136003)(376002)(396003)(39830400003)(346002)(366004)(186009)(1800799009)(451199024)(6506007)(6486002)(6512007)(83380400001)(31696002)(38100700002)(36756003)(2616005)(110136005)(26005)(44832011)(316002)(2906002)(66476007)(66946007)(66556008)(8936002)(8676002)(31686004)(41300700001)(5660300002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGNydzZCM1d4T0JqTUprTGdLQytYZHpHTDhOcHNSR29KcWFodTQydmd0cllO?= =?utf-8?B?cEhrWkVMMGxoSHBUa0l6SEQ5c2pUQThoZWFKTGQwcHNQbTgrQXhBUFc4V2cr?= =?utf-8?B?SWlCVmNXQVh4cW1kSnNFb2FqNGdUTlUxQytRdmZkZDd2RzA2WTRrTzFucVhH?= =?utf-8?B?akZzZFhwdjNhZWRFSlZJWkNuRGFSYmNPOE5qR2RTcUFBVFdGOHJwUno2VllL?= =?utf-8?B?NVFNazE4azBqVG4weHZMRzVmNFh0Z1ZMTnEyK3dOV3FmNk5xdXpOUGZMOS9O?= =?utf-8?B?QjhhZWhwbGNQa2lzS282Wk4yMlU0TW1RbFRhVS9iOXlUQy9Ld1VQWnRUVHVy?= =?utf-8?B?M0U4eC9qY1JyWlNqRUxiMm1sU3E4ekRxM09FbFhZYVEwNFNRcDJCc0g5Q2oy?= =?utf-8?B?OVhERGIwaGc4MlozeGNxQTYrOEkxSC9UdXh4cHkwVWpMbzcvWTRELzBLZHhJ?= =?utf-8?B?OVp0QjBsR3NCWFBxSHRCRmNuQlJuaWtKUUczZmlzYnQwT0ZVdHpmYUVWQ0dp?= =?utf-8?B?dHd5S0V4QTE0ZGRiMmFqSDVNTittemlrejZmNVdjaE5UekdwWWM1Wk53YStW?= =?utf-8?B?Qm1BZ3FvTXZqNlNUZTRMVlhmdzFsYy9mWkdGclVVNlFIczIrZlNvazBJbS82?= =?utf-8?B?QUN5VWVVSmU2MlcyWjIrNXorKzdRQVE2bmJqMTk0ZHN2dkY0N3BFdDBXWGZ0?= =?utf-8?B?VjJTb0FDbUUwWG5MZ2xFK2QvRWdpaEN5M0ozWlkrNFVGSm5rWnREcjZucmJV?= =?utf-8?B?WDdVMGM1cEdRRG1sZU5mMEoxMGhOUEJwYlFFUThqaHV1YzhYb056UFEvRXNZ?= =?utf-8?B?dG9FNUY3RWs3Sk9IaUgxbjBjcHJ4M09pSnJVb0hkazZhd3Z5YUEwajBmbkpC?= =?utf-8?B?S3NKUW5qeTV0eG5yR0FJWjAwT0orU1hQWi9CYlQxNnhqSkl4THZKTWg1NDEr?= =?utf-8?B?YlJrdkdVbkFEUHVUcUxkSG9wVXpMSVF0NEVUR1I2YlJjR05hQVAvZ2pYZ3hE?= =?utf-8?B?WlZnU3p3SGZvVEtOcU9EME5vUGJBa3ZIYUF3cHg0SHlzb0tnd1hEaWxEd3ox?= =?utf-8?B?b01vdEtrcEwrWTdYRi9GRDhhNWhDanRjRnFXYyt1aGg4T0V4ZHVjK21PeHJm?= =?utf-8?B?ZVc0dDd0REhkUmxsQ2EzZW5aT1N2QTdGaXNyckYzcUFnbTFEZmp0SDdVb2Rx?= =?utf-8?B?YlNkeG51UXJONEROcHJncU1tQzc5aUdLeHdzUk9jc3dpdVlhTis5Y0NBL3Z6?= =?utf-8?B?SHlNQ0dNNlBwNktKWEY2SHQyUVhpRkMwWSsyelNGZndONnhDRHBYOU56bjFX?= =?utf-8?B?Y3BpbDBqNHlzWDAxSFpHcnZOUU51VmtTcCt1aXk4dmZtSndDYmRMbDJzVU9K?= =?utf-8?B?Yytrd29PTnVrVUUyZk5hZVBybmJLTjBBbHU5NWlzRFZpUHpXRW5tWHhsMUVN?= =?utf-8?B?VFlkZHVxY01ZeDVRSmhFb2FwMUlOVXIrd3Nob0R0NVhJc3NFNGZaa0hjdkpE?= =?utf-8?B?ZTdjKysvZFIyVHF3WWhVVFdzZ3Q3ZlpDSjVxQ291TzdVaGIwM3ByejdMK1ow?= =?utf-8?B?alN1VGNJNDM0RFQ1NFcrNTllRlFXZ1FIVHUzOS9NTU1JSVZuNTV4aFhWVTI2?= =?utf-8?B?WlJWUEpiM3BwbDNzRzNqOE8ycEU4QkVmc2J2aGsvUkNQSElNRkxXYUNORy9P?= =?utf-8?B?V21zZWJvcEhaTy9rSk51M1lSZ0VxeGxJdXFBVldLcTMxUTNLd3ZjM2t3SkJu?= =?utf-8?B?cXVuUnF6MXN0cDg1VElieTErK3JuTzBSYytnSk1mNHpSL0NiamdkVTZpaEZP?= =?utf-8?B?NDlBZEQvZjJjTUM1cjlDQ1B0SXY3RGJtY3NSNkdhVktxWjlSVG5zb0MyWUI3?= =?utf-8?B?NFc0UmdxV0l2ZlQyODUzeUlISTRpUVZ3a0xwdlRMNzlWK0tUS2tuRG5MakpZ?= =?utf-8?B?YjZiODZ0OTZsc1dzZkhGYlorNjV2OFFaQTRqS2FhNXpJVFplYytXSUF1bFFJ?= =?utf-8?B?dDNNQlMramFXWVllOWFaeEJhbUtGRk10dUd2V05GYzk4K3h3akt2M2VnajBu?= =?utf-8?B?OE1NMzNxWU9BL1gxUlJCbTBLS2ZIOTBkQ01vTzNNTjVZVlRSQmZRaXRMUHBH?= =?utf-8?B?bDdocTRjYlhMRFBldDd1V3Fsb1dZbFBLT3B0UlMxU0ZPdy90YVZnM3I2Q2JK?= =?utf-8?B?eFE9PQ==?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f342476-0e60-4c2d-afc9-08dbb3b4f3ee X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 17:23:17.2209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zd1bjlwx6A4mHS82fovzfwmESMAvGO5ZCullcUgyoqwTzJCylrv+ZBGQxULQSIdF+lvji+KElWpOMzeM91NfQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8396 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> diff --git a/gdb/ui.c b/gdb/ui.c >> index 8c04dc92b89e..2db899eb9c31 100644 >> --- a/gdb/ui.c >> +++ b/gdb/ui.c >> @@ -172,6 +172,57 @@ ui::lookup_interp (const char *name) >> >> /* See ui.h. */ >> >> +void >> +ui::set_current_interpreter (interp *interp, bool top_level) >> +{ >> + struct interp *old_interp = this->current_interpreter; > > Is there any way that we can assert something like: > > gdb_assert (this == interp->m_ui); > > we maybe need an interp::mi() accessor function. Ah lol, we had the same idea. I'll add a patch on top of this one to make this change, since I'd like to keep this one "just move stuff" as much as possible. >> diff --git a/gdb/ui.h b/gdb/ui.h >> index be89ab3d6848..4f6a32991d6d 100644 >> --- a/gdb/ui.h >> +++ b/gdb/ui.h >> @@ -167,6 +167,18 @@ struct ui : public intrusive_list_node >> interp_factory_register, return nullptr; otherwise return a pointer to >> the interpreter. */ >> interp *lookup_interp (const char *name); >> + >> + /* This sets the current interpreter of this UI to be INTERP. If INTERP has >> + not been initialized, then this will also run the init method. >> + >> + The TOP_LEVEL parameter tells if this new interpreter is > > I know these aren't your words, but could we take this chance to update > this text to: > > The TOP_LEVEL parameter is true if this new interpreter is > > which reads much nicer. I'll add a patch on top of this one to do this change. Simon