From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A8224384B0C0 for ; Wed, 17 Mar 2021 15:12:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A8224384B0C0 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12HFCMRx022659 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Mar 2021 11:12:27 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12HFCMRx022659 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 810B11E54D; Wed, 17 Mar 2021 11:12:22 -0400 (EDT) Subject: Re: [PATCH 2/3] Fix bkpt-other-inferior.exp race To: Pedro Alves , gdb-patches@sourceware.org References: <20210315234339.457551-1-pedro@palves.net> <20210315234339.457551-3-pedro@palves.net> From: Simon Marchi Message-ID: Date: Wed, 17 Mar 2021 11:12:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210315234339.457551-3-pedro@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 17 Mar 2021 15:12:22 +0000 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 15:12:30 -0000 On 2021-03-15 7:43 p.m., Pedro Alves wrote: > gdb.server/bkpt-other-inferior.exp sometimes fails like so: > > (gdb) inferior 2 > [Switching to inferior 2 [process 368191] ()] > [Switching to thread 2.1 (Thread 368191.368191)] > [remote] Sending packet: $m7ffff7fd0100,1#5b > [remote] Packet received: 48 > [remote] Sending packet: $m7ffff7fd0100,1#5b > [remote] Packet received: 48 > [remote] Sending packet: $m7ffff7fd0100,9#63 > [remote] Packet received: 4889e7e8e80c000049 > #0 0x00007ffff7fd0100 in ?? () > (gdb) PASS: gdb.server/bkpt-other-inferior.exp: inf 2: switch to inferior > break -q main > Breakpoint 2 at 0x1138: file /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.server/server.c, line 21. > (gdb) PASS: gdb.server/bkpt-other-inferior.exp: inf 2: set breakpoint > delete breakpoints > Delete all breakpoints? (y or n) y > (gdb) [remote] wait: enter > [remote] wait: exit > FAIL: gdb.server/bkpt-other-inferior.exp: inf 2: delete all breakpoints in delete_breakpoints (timeout) > ERROR: breakpoints not deleted > Remote debugging from host ::1, port 55876 > monitor exit > > The problem is here: > > (gdb) [remote] wait: enter > > The testcase isn't expecting any output after the prompt. This fixes > it by removing the anchor. I don't really understand what happens here. When I replicate the test manually, I don't see this pair of enter/exit. Also, since the test specifically exists to ensure there won't be communcation with the remote target when inserting the breakpoint, why should we expect the remote target's wait to get called? Is there a way to hack something to make the failure happen all the time? Simon