From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9352F3854551 for ; Fri, 18 Nov 2022 16:00:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9352F3854551 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 205361E0CB; Fri, 18 Nov 2022 11:00:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1668787241; bh=BYFh8kMr6cdsEJlFpL+OOc82+CTEM/+31fmvxTvFcWE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=j8lLi3vUCjPsWQhkr6cnN+o45N3I2q8zxSpQKCraFjQpcSV/r8LVHhLeR0yhqRnCN XvWWCXOAgZMTgpQwNIEfyvCUEJ29df2Ct4XPCJfa4Uhr5ceV4Z5QCwSmrfYWdOwk3c EI8dRSVn76yYTN/yB/W5W+s+vMXIT5ETxDKsVyZ4= Message-ID: Date: Fri, 18 Nov 2022 11:00:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH][PR build/29791] gnulib: Disable _GL_ATTRIBUTE_DEALLOC on Solaris Content-Language: en-US To: Rainer Orth , gdb-patches@sourceware.org References: From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/22 08:08, Rainer Orth wrote: > gdbsupport compilation badly fails with GCC 12 on Solaris, with errors > like > > ../gnulib/config.h:1693:72: error: ‘malloc’ attribute argument 1 is ambiguous > 1693 | # define _GL_ATTRIBUTE_DEALLOC(f, i) __attribute__ ((__malloc__ (f, i))) > | ^ > ../gnulib/config.h:1693:72: note: use a cast to the expected type to disambiguate > > We've not yet been able to determine where the ambiguity actually lies, > so this patch works around the issue by disabling _GL_ATTRIBUTE_DEALLOC > on Solaris, at least as a workaround for GDB 13. > > As Tom suggested in the PR, this is done using our infrastructure for > local gnulib patches. > > Tested on sparcv9-sun-solaris2.11, amd64-pc-solaris2.11, and > x86_64-pc-linux-gnu. > > Ok for trunk? Thanks, this is ok: Approved-By: Simon Marchi Simon