From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id C39FD3858D28 for ; Tue, 18 Apr 2023 08:43:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C39FD3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4A8B7211CE; Tue, 18 Apr 2023 08:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681807392; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8LYGB9OYPjUfY6gXndWN/sOf2eJeLgZoG8HSgtQB6Bw=; b=xdHZLKfe1pAElW7QeyqZm4gjWFMffwx15yH5flyeB9CSE0crOrxNyDGuk7nUDh5P1U2KJF JLjwRyWFM2EEX+seDOb1FiVQRx20YTPdIhQnX8hi3Z7DbrjCLf2hX7/EKCRPJkdHtSLBz1 ac+7ch+PK/QO3JmveSd/DXUUrEQ7awc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681807392; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8LYGB9OYPjUfY6gXndWN/sOf2eJeLgZoG8HSgtQB6Bw=; b=F1GbEYrE9BPkUig+s9eV+ACCy2KyI9TioEO45PA/I/DdhaZZTBEj2q2Mm48kzWKyIVsPoN unjDJOSJZ19BweBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 29EFC139CC; Tue, 18 Apr 2023 08:43:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 28YFCSBYPmS2DgAAMHmgww (envelope-from ); Tue, 18 Apr 2023 08:43:12 +0000 Message-ID: Date: Tue, 18 Apr 2023 10:43:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] gdb: Fix false match issue in skip_prologue_using_linetable Content-Language: en-US To: hev , Keith Seitz Cc: gdb-patches@sourceware.org References: <20230417162428.48426-1-r@hev.cc> <901e6d84-2476-9108-b79c-0a3747d02b2f@redhat.com> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/18/23 04:26, hev wrote: >> I have to ask, though, is there a way to write a test case for this? Maybe >> by using dw2-prologue-end.exp as an example? > I attempted to write a test case, but it did not work. I discovered this > issue while running the Rust debuginfo test[1] on LoongArch. As the > function entry alignment is 4-byte, which is the size of an instruction, > there is no padding between the two functions. This creates a possibility > of matching the start address of the next function. This is unlike x86, > which is why this problem does not occur on x86. I sincerely hope that this > information proves to be beneficial to you. Using this information I managed to write a regression test for this, I've attached it to a PR I opened for this issue ( https://sourceware.org/bugzilla/show_bug.cgi?id=30369 ). Thanks, - Tom