From: Simon Marchi <simon.marchi@ericsson.com>
To: GDB Administrator <gdbadmin@sourceware.org>,
<gdb-patches@sourceware.org>
Subject: Re: New ARI warning Wed Aug 29 01:57:16 UTC 2018
Date: Wed, 29 Aug 2018 14:27:00 -0000 [thread overview]
Message-ID: <cf2c51b2-dbfc-2565-ec45-bd76fc6c86de@ericsson.com> (raw)
In-Reply-To: <20180829015716.GA50222@sourceware.org>
On 2018-08-28 09:57 PM, GDB Administrator wrote:
> 120a121,122
>> gdb/csky-tdep.c:1612: gettext: trailing new line: A message should not have a trailing new line
> gdb/csky-tdep.c:1612: warning (_("Invalid breakpoint address 0x%x is an odd number.\n"),
I pushed this obvious patch to fix this warning:
From 2362e7f76adb395df19c867cd27c75f77a0ade6f Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Wed, 29 Aug 2018 10:26:11 -0400
Subject: [PATCH] Remove newline at end of warning message
... to fix this ARI warning:
gdb/csky-tdep.c:1612: gettext: trailing new line: A message should not have a trailing new line
gdb/csky-tdep.c:1612: warning (_("Invalid breakpoint address 0x%x is an odd number.\n"),
gdb/ChangeLog:
* csky-tdep.c (csky_memory_insert_breakpoint): Remove newline at
end of warning message.
---
gdb/ChangeLog | 5 +++++
gdb/csky-tdep.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 373e1b1..32054c6 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-29 Simon Marchi <simon.marchi@ericsson.com>
+
+ * csky-tdep.c (csky_memory_insert_breakpoint): Remove newline at
+ end of warning message.
+
2018-08-29 Alan Hayward <alan.hayward@arm.com>
PR gdb/22943:
diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c
index 997ca93..972ac59 100644
--- a/gdb/csky-tdep.c
+++ b/gdb/csky-tdep.c
@@ -1609,7 +1609,7 @@ csky_memory_insert_breakpoint (struct gdbarch *gdbarch,
/* Sanity-check bp_address. */
if (bp_tgt->reqstd_address % 2)
- warning (_("Invalid breakpoint address 0x%x is an odd number.\n"),
+ warning (_("Invalid breakpoint address 0x%x is an odd number."),
(unsigned int) bp_tgt->reqstd_address);
scoped_restore restore_memory
= make_scoped_restore_show_memory_breakpoints (1);
--
2.7.4
next prev parent reply other threads:[~2018-08-29 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 1:57 GDB Administrator
2018-08-29 14:27 ` Simon Marchi [this message]
2018-08-29 14:34 ` Simon Marchi
2018-08-29 16:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf2c51b2-dbfc-2565-ec45-bd76fc6c86de@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=gdbadmin@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).