From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id C3956385B835
 for <gdb-patches@sourceware.org>; Mon, 30 Mar 2020 15:40:34 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C3956385B835
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (unknown [192.222.164.54])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 50C761E581;
 Mon, 30 Mar 2020 11:40:34 -0400 (EDT)
Subject: Re: [PATCH 12/20] Remove DW_ADDR
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20200328192208.11324-1-tom@tromey.com>
 <20200328192208.11324-13-tom@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <cf4a4dc0-1315-03c8-99ba-924f4f09e0ad@simark.ca>
Date: Mon, 30 Mar 2020 11:40:33 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200328192208.11324-13-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <http://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Mar 2020 15:40:35 -0000

On 2020-03-28 3:22 p.m., Tom Tromey wrote:
> @@ -202,6 +203,17 @@ struct attribute
>      requires_reprocessing = 1;
>    }
>  
> +  /* Set this attribute to an address.  */
> +  void set_address (CORE_ADDR addr)
> +  {
> +    gdb_assert (form == DW_FORM_addr
> +		|| ((form == DW_FORM_addrx
> +		     || form == DW_FORM_GNU_addr_index)
> +		    && requires_reprocessing));

I wonder if we should assert

  gdb_assert (!requires_reprocessing);

in attribute::address and attribute::string.  Otherwise, we could miss
reprocessing an attribute and we'd return a bogus value, it seems.

Simon