From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 25266389200D for ; Mon, 25 May 2020 15:42:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 25266389200D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B39ED1E5F9; Mon, 25 May 2020 11:42:53 -0400 (EDT) Subject: Re: [PATCH v5 1/9] gdb: Move construct_inferior_arguments to gdbsupport To: Michael Weghorn , gdb-patches@sourceware.org References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200520162115.713005-1-m.weghorn@posteo.de> From: Simon Marchi Message-ID: Date: Mon, 25 May 2020 11:42:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200520162115.713005-1-m.weghorn@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 15:42:55 -0000 On 2020-05-20 12:21 p.m., Michael Weghorn via Gdb-patches wrote: > This moves the function construct_inferior_arguments from > gdb/inferior.h and gdb/infcmd.c to gdbsupport/common-inferior.{h,cc}. > While at it, also move the function's comment to the header file > to align with current standards. > > The intention is to use it from gdbserver in a follow-up commit. > > gdb/ChangeLog: > > 2020-05-13 Michael Weghorn > > * infcmd.c, inferior.h: (construct_inferior_arguments): > Moved function from here to gdbsupport/common-inferior.{h,cc} > > gdbsupport/ChangeLog: > > w020-05-13 Michael Weghorn > > * common-inferior.h, common-inferior.cc: (construct_inferior_arguments): > Move function here from gdb/infcmd.c, gdb/inferior.h I've pushed the whole series, we can take a look at improving how inferior arguments are passed to gdb_run_cmd as a separate change. Thanks a lot for your contribution and perseverance! Simon