From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A4A983858407 for ; Mon, 27 Mar 2023 14:26:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A4A983858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [192.168.0.101] (modemcable194.137-20-96.mc.videotron.ca [96.20.137.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F1E771E0D2; Mon, 27 Mar 2023 10:26:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1679927170; bh=F51xNkJkE+vtU8LYcfwetS6CN8jH/cYyDZFDMfuDxOs=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Pbs7LALPxde87DncGRZBsL7WOjOGLXfJdnyUHIn+RiMQf8CrO9BSfTjsA8Y+8XTto X1K/Onbm4dl43nvap4+BjNrBDQQSor0MzI3Tdsp0Lwv8//x72gFKYuHykF0ub09S66 fFAcLwG50rAxppVIpFJ4RcCkuEnnd4DTUKIUK3nw= Message-ID: Date: Mon, 27 Mar 2023 10:26:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] Change symbol::line to unsigned int To: Tom Tromey , gdb-patches@sourceware.org References: <20230327134533.121165-1-tromey@adacore.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20230327134533.121165-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/27/23 09:45, Tom Tromey via Gdb-patches wrote: > A user here at AdaCore noticed that, when debugging a certain program, > a stack frame reported line 34358, where it should have been line > 99894. > > After debugging a bit, I discovered: > > (top) p (99894 & ~65536) > $60 = 34358 > > That line, symbol::line is too narrow. > > This patch widens the member and changes all the uses that currently > use the narrower type. Looks fine to me: Approved-By: Simon Marchi Simon