From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98527 invoked by alias); 9 Sep 2017 18:35:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98240 invoked by uid 89); 9 Sep 2017 18:35:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=wonders, Hx-languages-length:425 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Sep 2017 18:35:26 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v89IZJip012677 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 9 Sep 2017 14:35:24 -0400 Received: by simark.ca (Postfix, from userid 112) id BCD6C1EAAC; Sat, 9 Sep 2017 14:35:19 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 113331E984; Sat, 9 Sep 2017 14:35:18 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 09 Sep 2017 18:35:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 4/7] Use ui_out_emit_tuple in disasm.c In-Reply-To: <20170909153540.15008-5-tom@tromey.com> References: <20170909153540.15008-1-tom@tromey.com> <20170909153540.15008-5-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 9 Sep 2017 18:35:19 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00247.txt.bz2 On 2017-09-09 17:35, Tom Tromey wrote: > This changes one spot in disasm.c to use ui_out_emit_tuple. This > patch required a large reindentation, so I've separated it out. "git show -w" does wonders! The hard part is figuring out if there's something else in this big function using cleanups (and therefore if the cleanup variable should be kept). Anyway, this LGTM. Simon