public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: tdevries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle SIGSEGV in gdb selftests
Date: Tue, 17 Jan 2023 11:22:56 -0500	[thread overview]
Message-ID: <cfb431fa-4f03-07cb-ab98-09d8cbd39c58@simark.ca> (raw)
In-Reply-To: <87bkmx2kwf.fsf@tromey.com>

On 1/17/23 11:20, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
> 
>>> Shouldn't the SIGSEGV -re be before the `-i $inferior_spawn_id`?
>>> Otherwise we expect the "received signal SIGSEGV" message to come from
>>> the debugged GDB, when it's the top GDB that will print it (like when
>>> debugging any other test program).
>>>
>>> I think we don't see the problem when testing with native because
>>> the top and bottom GDBs share the same spawn id.
> 
> Makes sense to me.
> 
> Simon> Here's a patch to fix it, with a commit message.
> 
> Looks good to me.
> 
> Tom

Thanks, pushed.

Simon

      reply	other threads:[~2023-01-17 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15 21:14 Tom Tromey
2022-12-16 15:17 ` Tom de Vries
2022-12-16 16:11   ` Tom Tromey
2022-12-26  8:02     ` tdevries
2023-01-14  1:11       ` Simon Marchi
2023-01-14  1:19         ` Simon Marchi
2023-01-17 16:20           ` Tom Tromey
2023-01-17 16:22             ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfb431fa-4f03-07cb-ab98-09d8cbd39c58@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).