public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@arm.com>
To: Jan Kratochvil <jkratochvil@azul.com>
Cc: gdb-patches@sourceware.org, Alan Hayward <alan.hayward@arm.com>
Subject: Re: [PING^2] [PATCH] gdb/arm: Fix backtrace for pthread_cond_timedwait
Date: Thu, 30 Mar 2023 17:09:59 +0100	[thread overview]
Message-ID: <cfe0610d-1967-26d0-c97d-965ba2f11d7c@arm.com> (raw)
In-Reply-To: <ac4b5804-3a8b-f938-a6d7-96730b510edf@arm.com>

On 3/30/23 15:30, Luis Machado wrote:
> On 3/20/23 12:51, Jan Kratochvil wrote:
>> [PATCH v4] gdb/arm: Fix backtrace for pthread_cond_timedwait
>> https://sourceware.org/pipermail/gdb-patches/2023-February/197413.html
>>
>> Hi Luis,
>>
>> On Sat, 25 Feb 2023 00:56:12 +0800, Luis Machado wrote:
>>> I gave this a try across Ubuntu 22.04/20.04 and aarch64/arm. All of them run like so:
>>>
>>> UNTESTED: gdb.arch/arm-pthread_cond_timedwait-bt.exp: pc points to svc
>>>
>>> Is that what you were expecting to see?
>>
>> unfortunately not but could you give the v4 patch a try? A single host should
>> be enough. I am not sure why my machine disassembles as "svc 0x00000000" while
>> yours as "svc 0", I did not investigate it more.
> 
> Sure. I'll give it a try and we'll let you know.
> 
>>
>>
>> Thanks,
>> Jan
> 

I gave this a try and I get full PASSes now (10 of them). For aarch64 we bail out eventually
and report an untested case.

This looks good to me, but you'll need to adjust the copyright years and remove the template section
in the testcase:

+# This serves as a template for writing new test cases.  Replace this with
+# a description of what this test case tests.

Sorry for the late reply.

Thanks,
Luis

  reply	other threads:[~2023-03-30 16:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-31  8:48 Jan Kratochvil
2023-01-16 16:10 ` [PING] " Jan Kratochvil
2023-01-17 11:14   ` Luis Machado
2023-01-18 11:51     ` Jan Kratochvil
2023-01-18 14:22       ` Luis Machado
2022-12-31  8:48         ` [PATCH v2] " Jan Kratochvil
2023-01-19  3:15         ` [PING] [PATCH] " Jan Kratochvil
2023-01-20 17:41           ` Luis Machado
2022-12-31  8:48             ` [PATCH v3] " Jan Kratochvil
2023-02-24 13:38             ` [PING] [PATCH] " Jan Kratochvil
2023-02-24 16:56               ` Luis Machado
2022-12-31  8:48                 ` [PATCH v4] " Jan Kratochvil
2023-02-25 10:04                 ` [PING] [PATCH] " Jan Kratochvil
2023-03-20 12:51                   ` [PING^2] " Jan Kratochvil
2023-03-30 14:30                     ` Luis Machado
2023-03-30 16:09                       ` Luis Machado [this message]
2023-04-01 13:49                         ` [committed] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfe0610d-1967-26d0-c97d-965ba2f11d7c@arm.com \
    --to=luis.machado@arm.com \
    --cc=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jkratochvil@azul.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).