From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH 0/4] layout command changes
Date: Wed, 20 May 2015 23:17:00 -0000 [thread overview]
Message-ID: <cover.1432163460.git.andrew.burgess@embecosm.com> (raw)
This patch set replaces an earlier patch I posted here:
https://sourceware.org/ml/gdb-patches/2015-04/msg00185.html
In the previous patch I had to jump through some hoops in order to
support completion of the layout names like $FREGS. This was pretty
annoying as I had not realised these layouts existed until I started
writting the completer code...
...but it turns out that those layout names don't work anyway, and
have not done so for some time. I didn't figure out exactly when they
broke, but I believe they were broken in 6.8.
Still, it doesn't matter, as we have the 'tui regs' command, which
does work, and does allow the register set displayed in tui to be
changed. This is for the best anyway (I think), personally, I felt
that managing both the layout, and the choice of register set all from
the layout command was too much overloading.
The first patch in this series removes the $FREGS style register set
names from the layout command, and cleans up all of the code relating
to them.
The second patch is a much simpler version of command completion
support for layout names.
The third and forth patches fix small tui related issues that I
spotted during testing.
Thanks,
Andrew
--
Andrew Burgess (4):
gdb: Remove register class specific layout names.
gdb: Add completer for layout command.
gdb: Don't call tui_enable too early.
gdb: Add cleanup to avoid memory leak on error.
gdb/ChangeLog | 49 ++++++
gdb/testsuite/ChangeLog | 5 +
gdb/testsuite/gdb.base/completion.exp | 19 +++
gdb/tui/tui-data.c | 10 +-
gdb/tui/tui-data.h | 23 ---
gdb/tui/tui-layout.c | 296 +++++++++++++++-------------------
gdb/tui/tui-layout.h | 3 +-
gdb/tui/tui.c | 8 +-
8 files changed, 210 insertions(+), 203 deletions(-)
--
2.4.0
next reply other threads:[~2015-05-20 23:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 23:17 Andrew Burgess [this message]
2015-05-20 23:18 ` [PATCH 3/4] gdb: Don't call tui_enable too early Andrew Burgess
2015-05-20 23:18 ` [PATCH 1/4] gdb: Remove register class specific layout names Andrew Burgess
2015-05-21 8:42 ` Pedro Alves
2015-05-21 11:33 ` Andrew Burgess
2015-05-21 11:34 ` Pedro Alves
2015-05-21 12:25 ` Andrew Burgess
2015-05-21 13:17 ` Pedro Alves
2015-05-20 23:18 ` [PATCH 2/4] gdb: Add completer for layout command Andrew Burgess
2015-05-21 0:25 ` Keith Seitz
2015-05-21 7:10 ` Andrew Burgess
2015-05-20 23:18 ` [PATCH 4/4] gdb: Add cleanup to avoid memory leak on error Andrew Burgess
2015-05-21 8:12 ` [PATCH 0/4] layout command changes Pedro Alves
2015-05-21 8:35 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1432163460.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).