From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52902 invoked by alias); 8 May 2018 16:58:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49963 invoked by uid 89); 8 May 2018 16:58:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 May 2018 16:58:51 +0000 Received: by mail-wm0-f68.google.com with SMTP id n10-v6so22775688wmc.1 for ; Tue, 08 May 2018 09:58:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rqqNVlMB0VxuGEHqwOgLZ1u4/+FcLTb3syo7Ptk8EOo=; b=jzks0ePTS5UhgvlcfsGIqgh+IiG8TGGrwAu/06ImiLKFVlW0UrpYjVJ6MYlV9f+eM8 tKMRLg7wtTtyGS9HS0HHudMWLM2e3LQO13QssAbVHqbWr+jOL+ZxveaeUd/+PUHDBVB8 WKqrqmrGwsDm6QtAZB889nO2XZ/qFMDTB7NGX+s0HqItGOQRYLQY7agUHA76JsrPAFL5 ux10riwEDIyM/fpAq0HdceLjNiF66O8ATvXx820a0fa/PYpJNW0v8ltGyPz4rH4VlOXI 0S3uZxJ6m8hQ8woCrx2NmpHWWDWeIuS7QDas3c0FC1ClupQdX7L6GdO0xNRbxqVsqvWu lOBQ== X-Gm-Message-State: ALKqPweZ0zth4j7Cuid+EiTSu58ZSnaiyDftSAJqy787WnVgcG7JlEXo Je9CoF2CZSl25QpYXns8RLMDaV1B X-Google-Smtp-Source: AB8JxZrcLphJyib3KqnZGy1hFElbWdV/VDJ7OcVp1pK829S9AW79s2a2VoBZYrWllYGWPlFv38RVow== X-Received: by 10.28.234.206 with SMTP id g75mr3724708wmi.76.1525798729576; Tue, 08 May 2018 09:58:49 -0700 (PDT) Received: from localhost (host81-147-175-127.range81-147.btcentralplus.com. [81.147.175.127]) by smtp.gmail.com with ESMTPSA id y68-v6sm33608077wrb.91.2018.05.08.09.58.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 09:58:48 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 0/2] Changes to frame selection. Date: Tue, 08 May 2018 16:58:00 -0000 Message-Id: X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00185.txt.bz2 This is an update of this patch series: https://sourceware.org/ml/gdb-patches/2015-09/msg00248.html In summary this patch means that instead of simply: (gdb) frame NUMBER|ADDRESS-OF-EXISTING-FRAME|ADDRESS-OF-NEW-FRAME we now have: (gdb) frame NUMBER (gdb) frame level NUMBER (gdb) frame address ADDRESS-OF-EXISTING-FRAME (gdb) frame create ADDRESS-OF-NEW-FRAME (gdb) frame function NAME The same flexibility is added to 'select-frame' and 'info frame'. >From the original patch series, some of the patches are no longer needed (due to other upstream changes) and some of the patches were already approved and merged. It is only the last two patches that are needed, and these are presented here. Patch #1 is preperation work, and is just a rebase of what I had before. This patch was actually approved previously, but I didn't merge it as without the second patch this doesn't make much sense. Patch #2 is the interesting stuff, and this has been rebased, and updated inline with the feedback I originally got, specifically, the frame specification is now implemented using sub-commands, rather than using a single parse function. I'm aware of this patch series: https://sourceware.org/ml/gdb-patches/2018-05/msg00152.html That also makes changes to the 'frame' command, and though there will obviously be textual conflicts, I don't think there's any functionality conflicts. -- Andrew Burgess (2): gdb: Split func_command into two parts. gdb: Change how frames are selected for 'frame' and 'info frame'. gdb/ChangeLog | 40 ++ gdb/NEWS | 29 ++ gdb/cli/cli-decode.c | 44 ++- gdb/command.h | 14 + gdb/doc/ChangeLog | 8 + gdb/doc/gdb.texinfo | 91 +++-- gdb/mi/mi-cmd-stack.c | 4 +- gdb/stack.c | 564 +++++++++++++++++++--------- gdb/stack.h | 2 +- gdb/testsuite/ChangeLog | 7 + gdb/testsuite/gdb.base/frame-selection.c | 52 +++ gdb/testsuite/gdb.base/frame-selection.exp | 156 ++++++++ gdb/testsuite/gdb.mi/mi-frame-selection.c | 34 ++ gdb/testsuite/gdb.mi/mi-frame-selection.exp | 90 +++++ 14 files changed, 920 insertions(+), 215 deletions(-) create mode 100644 gdb/testsuite/gdb.base/frame-selection.c create mode 100644 gdb/testsuite/gdb.base/frame-selection.exp create mode 100644 gdb/testsuite/gdb.mi/mi-frame-selection.c create mode 100644 gdb/testsuite/gdb.mi/mi-frame-selection.exp -- 2.14.3