From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103317 invoked by alias); 13 Aug 2018 22:20:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103301 invoked by uid 89); 13 Aug 2018 22:20:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=tighten, historically X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Aug 2018 22:20:17 +0000 Received: by mail-wm0-f41.google.com with SMTP id q8-v6so10331021wmq.4 for ; Mon, 13 Aug 2018 15:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GQRc48Ei91SIz5j9UrrQAdxC8VQBbiOu6XcDwFEedS4=; b=cnVMrkOC83Pl4Z5hxLV2hLaICr7dBpPSdR6c5iSKk+JYgYw7wgLgJPu1DwH8xstH2n Z4Ik8q8jELecGZtwVCEiMhYt1BK/90IWXutt08xzvoFfovf+Jazz2MulyqXjEq4ecut+ /r5FvGkOhp3MoBfL5hSSJzk2WaCUwsQWkRrJ/AvOhDOw1AiRuKECxdSxc4ZATMjgykKq J6kbTRVPYzbEcitknqk0dweIqDlmCZfe7/h6nz8mZmq4FVSHz0FSaaMRE4zCLERdZoqK N4+klnQnPBS+JwDKyeHDMT6doFFRYbMiWs5K0hBenegkSO3eUKUZv4Aq6jqBCRO83peI /CGQ== Return-Path: Received: from localhost (host81-140-215-41.range81-140.btcentralplus.com. [81.140.215.41]) by smtp.gmail.com with ESMTPSA id u1-v6sm12485211wrm.53.2018.08.13.15.20.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Aug 2018 15:20:13 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Philippe Waroquiers , Eli Zaretskii , Andrew Burgess Subject: [PATCHv5 0/2] gdb: Change how frames are selected for 'frame' and 'info frame'. Date: Mon, 13 Aug 2018 22:20:00 -0000 Message-Id: In-Reply-To: <20180725181406.GA3155@embecosm.com> References: <20180725181406.GA3155@embecosm.com> X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00335.txt.bz2 Given a lack of feedback on v4, I've put together two alternative versions to pick between... (A) In this version I took onboard the feedback from Eli and Philippe that using "level" might be confusing to users, as "number" is historically what has been used for the integer label we give to frames. The command for selecting a frame by integer is now, 'frame number ' and almost all references to "level" have now been removed from the patch. (B) In this version I've taken onboard the advice from Philippe, identifying places in the patch where I was mixing use of "level" and "number". I've doubled down on "level" and removed most uses of "number" from the patch. If we select patch 'A' then me might want to update 'frame apply level ...' to 'frame apply number ...' for consistency. If we select patch 'B' then we will probably need a follow up patch that goes through the documentation to tighten up references to "number" vs "level". I really don't mind which approach we take, I guess I'd probably pick 'B' over 'A' given we already have 'frame apply level ...' in GDB, but if there's preference for 'A' then that's fine. I'm also happy to do the follow up patches once we have some agreement on which way to go. Thanks, Andrew --- Andrew Burgess (1): gdb: Change how frames are selected for 'frame' and 'info frame'. gdb/ChangeLog | 36 ++ gdb/NEWS | 8 + gdb/cli/cli-decode.c | 44 ++- gdb/command.h | 14 + gdb/doc/ChangeLog | 8 + gdb/doc/gdb.texinfo | 108 ++++-- gdb/mi/mi-cmd-stack.c | 4 +- gdb/stack.c | 535 +++++++++++++++++++--------- gdb/stack.h | 2 +- gdb/testsuite/ChangeLog | 7 + gdb/testsuite/gdb.base/frame-selection.c | 52 +++ gdb/testsuite/gdb.base/frame-selection.exp | 157 ++++++++ gdb/testsuite/gdb.mi/mi-frame-selection.c | 34 ++ gdb/testsuite/gdb.mi/mi-frame-selection.exp | 89 +++++ 14 files changed, 896 insertions(+), 202 deletions(-) create mode 100644 gdb/testsuite/gdb.base/frame-selection.c create mode 100644 gdb/testsuite/gdb.base/frame-selection.exp create mode 100644 gdb/testsuite/gdb.mi/mi-frame-selection.c create mode 100644 gdb/testsuite/gdb.mi/mi-frame-selection.exp -- 2.14.4