From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111691 invoked by alias); 16 Jan 2020 00:48:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111555 invoked by uid 89); 16 Jan 2020 00:48:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=tuidisasmc, tui-io.c, burgess, helped X-HELO: mail-wm1-f49.google.com Received: from mail-wm1-f49.google.com (HELO mail-wm1-f49.google.com) (209.85.128.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2020 00:48:24 +0000 Received: by mail-wm1-f49.google.com with SMTP id u2so1979526wmc.3 for ; Wed, 15 Jan 2020 16:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pJmvnJiSzNp7DwF6NhbDwQtEcaXgBsY6zW9O9nsY1NI=; b=CTEtA630gYSWEb47PGx2xTz6navrVIuCF1Okhqd8cpPxgON5O+f8ew1pWlJTyE6QuH 5pU9I5NoONSE9kylJDlRfo+G5DCyET5JMZRebl8XAb4r2XGHuPvWdzrtms7EjUQqJpKG Ha4m75T1cArCspN/Dx2nydKotV5ond9DbK4ahZ3SpUmrAiymW0bE+Galdve3JMVVU6br 77khNKsoTd7aM5ZJbZyXFlLHC4oi6+hYnfo6A8WPSj5TbBMTn2/TjzbuazmqCFr1lygS IywoRxOCfA6J9q0iQCBDfes8UceSIeV4lcHTsWUSdljPdsndoWnjKOE9SF0M3Pax8zat +mPA== Return-Path: Received: from localhost (host86-191-239-73.range86-191.btcentralplus.com. [86.191.239.73]) by smtp.gmail.com with ESMTPSA id n8sm26825904wrx.42.2020.01.15.16.48.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Jan 2020 16:48:21 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Shahab Vahedi , Pedro Alves , Tom Tromey , Andrew Burgess Subject: [PATCHv2 0/2] gdb/tui: Assembler window scrolling fixes Date: Thu, 16 Jan 2020 00:48:00 -0000 Message-Id: In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00439.txt.bz2 This revision addresses the issues raised by Shahab, as well as making the improvements Tom pointed out. I looked at changing the TERM type from ansi to xterm as Tom suggested, but figuring out all of the extra control sequences that are sent was taking too much effort. I might try to revisit this when I have more time, but I don't plan to do this in the immediate future. I did start adding a mechanism to try and detect when the user tries to scroll and we're already at the end of the output (or the beginning), and this helped in the scroll down case, but I still need to figure out how to use this in the scroll up case, so for now I've not included this work in this patch set. There's still some things I think could be improved with the assembler scrolling - the user is currenly "trapped" inside the continuous memory region that the $pc starts in, they can't scroll to any disjoint code region, but this never worked before either, so this isn't a regression. I do have an idea for how to fix this, but I'm hoping to merge this set first, and work on the multi-section support when I can find some time later. Comments/feedback welcome as always, Thanks, Andrew --- Andrew Burgess (1): gdb/tui: asm window handles invalid memory and scrolls better Pedro Alves (1): gdb/tui: Prevent exceptions from trying to cross readline gdb/ChangeLog | 17 +++ gdb/minsyms.c | 41 ++++-- gdb/minsyms.h | 17 ++- gdb/testsuite/ChangeLog | 4 + gdb/testsuite/gdb.tui/tui-layout-asm.exp | 41 ++++++ gdb/tui/tui-disasm.c | 243 +++++++++++++++++++++++-------- gdb/tui/tui-io.c | 31 +++- 7 files changed, 313 insertions(+), 81 deletions(-) -- 2.14.5