From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/7] Language Class Hierarchy Conversion (Prt 3)
Date: Thu, 18 Jun 2020 23:31:47 +0100 [thread overview]
Message-ID: <cover.1592519094.git.andrew.burgess@embecosm.com> (raw)
In this third patch set I convert the last remaining function pointers
in the language_base structure into member function in language_defn.
There wasn't anything particularaly tricky in this batch.
After this set my plans are (in no particular order):
- Convert at least some of the data members in language_base into
member function in language_defn.
- Move some of the language classes into header files so that member
functions can be defined in different .c files. This will allow
me to remove most of the member functions that currently just
redirect to a function in another file.
- Possibly restructure the language class hierarchy to increase the
amount of sharing that exists between similar languages.
- Make more of the per-language helper functions private functions
within the language classes.
Thoughts, feedback, or ideas always welcome.
Thanks,
Andrew
---
Andrew Burgess (7):
gdb: Convert language la_parser field to a method
gdb: Convert language la_post_parser field to a method
gdb: Convert language la_emitchar field to a method
gdb: Convert language la_printchar field to a method
gdb: Convert language la_printstr field to a method
gdb: Convert language la_print_typedef field to a method
gdb: Convert language la_is_string_type_p field to a method
gdb/ChangeLog | 271 ++++++++++++++++++++++++++++++++++++++
gdb/ada-lang.c | 118 ++++++++++-------
gdb/c-lang.c | 28 ----
gdb/d-lang.c | 15 +--
gdb/f-lang.c | 132 +++++++++----------
gdb/go-lang.c | 35 +++--
gdb/language.c | 213 ++++++++++++++++++++++--------
gdb/language.h | 103 ++++++++-------
gdb/m2-lang.c | 324 +++++++++++++++++++++++-----------------------
gdb/objc-lang.c | 7 -
gdb/opencl-lang.c | 7 -
gdb/p-lang.c | 274 ++++++++++++++++++++-------------------
gdb/p-lang.h | 4 -
gdb/parse.c | 13 +-
gdb/parser-defs.h | 3 -
gdb/rust-lang.c | 162 ++++++++++++-----------
gdb/typeprint.c | 9 --
gdb/valprint.c | 2 +-
18 files changed, 1033 insertions(+), 687 deletions(-)
--
2.25.4
next reply other threads:[~2020-06-18 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 22:31 Andrew Burgess [this message]
2020-06-18 22:31 ` [PATCH 1/7] gdb: Convert language la_parser field to a method Andrew Burgess
2020-06-18 22:31 ` [PATCH 2/7] gdb: Convert language la_post_parser " Andrew Burgess
2020-06-18 22:31 ` [PATCH 3/7] gdb: Convert language la_emitchar " Andrew Burgess
2020-06-18 22:31 ` [PATCH 4/7] gdb: Convert language la_printchar " Andrew Burgess
2020-06-18 22:31 ` [PATCH 5/7] gdb: Convert language la_printstr " Andrew Burgess
2020-06-18 22:31 ` [PATCH 6/7] gdb: Convert language la_print_typedef " Andrew Burgess
2020-06-18 22:31 ` [PATCH 7/7] gdb: Convert language la_is_string_type_p " Andrew Burgess
2020-06-19 14:25 ` [PATCH 0/7] Language Class Hierarchy Conversion (Prt 3) Tom Tromey
2020-06-19 16:18 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1592519094.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).