From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/3] Prevent bad conditions from putting breakpoints into broken state
Date: Mon, 29 Jun 2020 15:48:25 +0200 [thread overview]
Message-ID: <cover.1593438119.git.tankut.baris.aktemur@intel.com> (raw)
Hi,
If the condition of a breakpoint is "bad" (e.g. has unresolved
symbols, syntax errors, etc.), the breakpoint goes into a broken state
where the condition string or the condition expressions are updated
inadvertently. This small series attempts to fix that.
Regards.
Baris
Tankut Baris Aktemur (3):
gdb/breakpoint: do not update the condition string if parsing the
condition fails
gdb/breakpoint: set the condition exp after parsing the condition
successfully
gdb/breakpoint: refactor 'set_breakpoint_condition'
gdb/breakpoint.c | 70 ++++++-------
gdb/testsuite/gdb.base/condbreak-bad.c | 24 +++++
gdb/testsuite/gdb.base/condbreak-bad.exp | 128 +++++++++++++++++++++++
3 files changed, 183 insertions(+), 39 deletions(-)
create mode 100644 gdb/testsuite/gdb.base/condbreak-bad.c
create mode 100644 gdb/testsuite/gdb.base/condbreak-bad.exp
--
2.17.1
next reply other threads:[~2020-06-29 13:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 13:48 Tankut Baris Aktemur [this message]
2020-06-29 13:48 ` [PATCH 1/3] gdb/breakpoint: do not update the condition string if parsing the condition fails Tankut Baris Aktemur
2020-07-22 13:12 ` Simon Marchi
2020-07-22 13:15 ` Simon Marchi
2020-06-29 13:48 ` [PATCH 2/3] gdb/breakpoint: set the condition exp after parsing the condition successfully Tankut Baris Aktemur
2020-07-22 13:21 ` Simon Marchi
2020-07-22 13:28 ` Simon Marchi
2020-07-22 15:29 ` Aktemur, Tankut Baris
2020-07-22 16:06 ` Simon Marchi
2020-07-23 7:11 ` Aktemur, Tankut Baris
2020-07-30 10:56 ` Aktemur, Tankut Baris
2020-07-30 15:15 ` Simon Marchi
2020-06-29 13:48 ` [PATCH 3/3] gdb/breakpoint: refactor 'set_breakpoint_condition' Tankut Baris Aktemur
2020-07-13 8:45 ` [PATCH 0/3] Prevent bad conditions from putting breakpoints into broken state Tankut Baris Aktemur
2020-07-21 9:08 ` Tankut Baris Aktemur
2020-07-22 18:24 ` Pedro Alves
2020-07-23 7:13 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1593438119.git.tankut.baris.aktemur@intel.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).