From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3EEAB3858D20 for ; Sun, 6 Feb 2022 14:13:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3EEAB3858D20 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-168-_NZNLrQtMiK5Ky0u6UrLDw-1; Sun, 06 Feb 2022 09:12:59 -0500 X-MC-Unique: _NZNLrQtMiK5Ky0u6UrLDw-1 Received: by mail-ed1-f70.google.com with SMTP id w15-20020a056402268f00b00408234dc1dfso6109872edd.16 for ; Sun, 06 Feb 2022 06:12:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B0ZV/Ejrdv/qLGXxs3RfIvdjHKmbvxSOa33DrM1An5U=; b=5/cs2gearoiWtngaETeWNlp31kFNrLLcpzOr9bxOT83mAst0Japt7emxe1kUqGPwNb vI0SxVlQZxo6y0z24U0QOMNLMbPnb3R4KGgJyhZGw1IANbiZ4cJaf9PRnPGMphc/LWPZ FpWPqDWUT0f2nHOzXouUyRIuobispxXtAnHfNiOQ6IJHKSQEUfsAvnZ5PC0lPz0NpnaE nWnj7IVjTC7ZJa8g59yHC2VWtk7z4QjB5EZH7ECLqMmq0prs/U4bGoPBFfQ9qswqakMj ZEiKb1hyi146iqJ8q1JTQwCYpKmM85RYeSCWhW1p2HeyCKJqtqeLhnn/p0mXjJQM8XCl tdhw== X-Gm-Message-State: AOAM531itFYdNP+ClN5xDCxaPgF1dzL4NUhvwGNXTPd+HXPim1Gk7iiv kwAsPPTXxDce0dKIdWAUoUGHcTbdQXcchXt01Pja5xN0SLx6zONzaIErR9ycnScZ4XyWPv0LMrV GHzEuDMPV1D2EWQHcMvTxCsfnj708bLeaSMrQG+2+vvkqQwUAGd893Qn6KtBqwvQ+5Y8dNqEXSg == X-Received: by 2002:a17:906:7751:: with SMTP id o17mr6583716ejn.265.1644156778218; Sun, 06 Feb 2022 06:12:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJx/IarOSAf2OFyqtGm77t6AgKEOKp/ywBIPdfjxMTwOPB5URrpt6oskdHumSsMOwymu0SFhkQ== X-Received: by 2002:a17:906:7751:: with SMTP id o17mr6583699ejn.265.1644156777918; Sun, 06 Feb 2022 06:12:57 -0800 (PST) Received: from localhost (92.40.178.36.threembb.co.uk. [92.40.178.36]) by smtp.gmail.com with ESMTPSA id m22sm2661613ejn.194.2022.02.06.06.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Feb 2022 06:12:57 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 00/15] TUI changes, new winwidth command and resizing changes Date: Sun, 6 Feb 2022 14:12:38 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Feb 2022 14:13:04 -0000 I pushed the first two patches from the v1 series, but the rest of that original series does need reviewing - those paches are included in v2 as patches 1 to 5. The remaining 10 patches in the v2 series mostly relate to changing how window resizing, and window layout occurs. The docs content in patches 1 and 5 of the v2 series is unchanged from v1, and was already reviewed, so no new docs review is required there. There is some new docs content in patch 6, but its pretty minor; a docs review is always welcome though. I'm hoping most of the changes in this series will be pretty non-controversial, the only patch which I think might be more of a personal taste issue is the very last one (left last for that reason). I'd suggest selecting the split layout, and then playing with window resizing to get a feel for the new behaviour. Feedback welcome. Thanks, Andrew --- Andrew Burgess (15): gdb: move some commands into the tui namespace gdb/tui: rename tui_layout_base::adjust_size to ::set_height gdb/tui: rename tui_layout_split:set_weights_from_heights gdb/testing/tui: add new functionality to tuiterm.exp gdb/tui: add new 'tui window width' command and 'winwidth' alias gdb/tui: add a tui debugging flag gdb/tui: add left_boxed_p and right_boxed_p member functions gdb/tui/testsuite: refactor new-layout.exp test gdb/tui: avoid fp exception when applying layouts gdb/tui: fairer distribution of excess space during apply gdb/tui: allow cmd window to change size in tui_layout_split::apply gdb/tui: support placing the cmd window into a horizontal layout gdb/testsuite: some additional tests in gdb.tui/scroll.exp gdb/tui: relax restrictions on window max height and width gdb/tui: fair split of delta after a resize gdb/NEWS | 25 ++ gdb/doc/gdb.texinfo | 41 ++- gdb/testsuite/gdb.tui/basic.exp | 4 +- gdb/testsuite/gdb.tui/empty.exp | 14 +- gdb/testsuite/gdb.tui/new-layout.exp | 100 +++++-- gdb/testsuite/gdb.tui/regs.exp | 4 +- gdb/testsuite/gdb.tui/scroll.exp | 4 + gdb/testsuite/gdb.tui/winheight.exp | 77 +++++ gdb/testsuite/gdb.tui/winwidth.exp | 63 ++++ gdb/testsuite/lib/tuiterm.exp | 82 +++++- gdb/tui/tui-command.c | 6 - gdb/tui/tui-command.h | 2 - gdb/tui/tui-layout.c | 419 +++++++++++++++++++++++---- gdb/tui/tui-layout.h | 201 ++++++++++++- gdb/tui/tui-win.c | 149 ++++++++-- gdb/tui/tui.c | 26 ++ gdb/tui/tui.h | 14 + 17 files changed, 1089 insertions(+), 142 deletions(-) create mode 100644 gdb/testsuite/gdb.tui/winwidth.exp -- 2.25.4