[PATCHv2 0/2] Fixing regression in mi -add-inferior command

[Andrew Burgess <aburgess@redhat.com>]

Hi Muhammad,

Thanks for working on this.  I've taken your patch and incorporated it
into the two patch series below, the first patch is still credited to
you, but has some changes:

 - During testing I noticed that with your patch, after -add-inferior,
   the new inferior has become the selected inferior.  I believe this
   was not the case before the original mutli-target patch, and isn't
   the case for the CLI command, so I fixed this, and extended the
   testing to cover this case.

 - I've moved the comment for switch_to_inferior_and_push_target into
   the .h file, and updated the .c file to match inline with the GDB
   style.

 - I tightened some of the pattern matching in the test case, for
   example, parsing the 'info inferiors' output to create an expected
   pattern for the connection name of the new inferior.

 - I tweaked the commit message to directly reference the commit that
   introduced the regression, I think this helps for anyone in the
   future trying to track down the history of a particular change.

Then I added a second commit that adds the --no-connection option for
the -add-inferior command.  I felt that it was important that these
two changes go in as a single series as, after the first commit, we
effectively loose the ability to create a new inferior with no
connection.

I'd welcome your feedback on both patches.  I think we just need to
wait for a doc review on patch #2, then we can probably get this
merged.

Thanks,
Andrew

---

Andrew Burgess (1):
  gdb/mi: add --no-connection to MI -add-inferior command

Muhammad Umair Sair via Gdb-patches (1):
  gdb/mi: fix regression in mi -add-inferior command

 gdb/doc/gdb.texinfo                      |  39 ++++++-
 gdb/inferior.c                           |   6 +-
 gdb/inferior.h                           |   7 ++
 gdb/mi/mi-main.c                         |  47 +++++++-
 gdb/testsuite/gdb.mi/mi-add-inferior.exp | 130 +++++++++++++++++++++++
 5 files changed, 217 insertions(+), 12 deletions(-)
 create mode 100644 gdb/testsuite/gdb.mi/mi-add-inferior.exp

-- 
2.25.4