From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DEE093858405 for ; Wed, 23 Mar 2022 10:50:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DEE093858405 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-335-a1vE_9ueN-SYd3Ye8kSYYA-1; Wed, 23 Mar 2022 06:50:31 -0400 X-MC-Unique: a1vE_9ueN-SYd3Ye8kSYYA-1 Received: by mail-wm1-f71.google.com with SMTP id f19-20020a7bcd13000000b0038c01defd5aso474085wmj.7 for ; Wed, 23 Mar 2022 03:50:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GYAFYrCoA1ZU5f9UyHiJcBaGhIC470JKSGGD35qjp2w=; b=v28nSy8D/ykTduRRi7UUNnb6tn8BO0O8Y2r3lpBFRgVfNtK/j12hm61xN6xpVHUe+Z VGeL4+AyNtXkjeRIwzn5VhOZpWse6owHlWwlvtnsyZkOcDEpMrhIGZKDOZtLFUu1DsLe B1liySXPVwFQZM+RjzfidR7/7jIjJMLFG9+rwNxFaLFhfkCp2493bZJV9XAQt+2dlDaE UOJ7ETVj79ntwVqPm+bJURwT3+xAWZBOrNHQpVNR2NSv07pf5oa67BNUQpSTP4oV+VR1 xrukvhs/GQT0tsca8KKsxDSQuFXZ4oFJfj8d6QWNmRLyNyAherctgkMSUe7ruDS6vewa 2sDg== X-Gm-Message-State: AOAM531QucZwj8EVIfi6DwItrZXBc+Ku86gGTrO2mLkbK9rKMbLLECzv Nx3Ea7Y+/WpS0D2TYUh+9bMWDuzkSHN4rbYUQEiKCDW0O3U7AAUOOqOgmnsaBF/6nN9vBqR/flw SZ1t8F2i5yyO5PlcUPTtUzQGaDLZolvGF1vdk9iC/jRH6RrdX/J9Hiu+/mjQh5qxqep+diQ6ULQ == X-Received: by 2002:a5d:460c:0:b0:204:62a:210c with SMTP id t12-20020a5d460c000000b00204062a210cmr15187064wrq.460.1648032630026; Wed, 23 Mar 2022 03:50:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzn9UCunyaV8ERlx6Tu82zLWmZqXW7jrZRKsfHFcrnIUuiMXacOsmOQWazXXU2nallpcT4ZDA== X-Received: by 2002:a5d:460c:0:b0:204:62a:210c with SMTP id t12-20020a5d460c000000b00204062a210cmr15187047wrq.460.1648032629784; Wed, 23 Mar 2022 03:50:29 -0700 (PDT) Received: from localhost (host109-158-45-15.range109-158.btcentralplus.com. [109.158.45.15]) by smtp.gmail.com with ESMTPSA id f8-20020a05600c154800b0038cc1acc02fsm1506871wmg.24.2022.03.23.03.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 03:50:29 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 0/3] Fix for 'make tags' build rule Date: Wed, 23 Mar 2022 10:50:23 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2022 10:50:35 -0000 Hi Reuben, Thanks for working on this, sorry your original patch didn't get merged. I took a look at your updated patch, and noticed what I think is a merge issue with your update, you've removed gdb_select.h, but added back in gdb_regex.h, I don't think this is intentional. Anyway, I was going to fix that and push your patch, but first I thought I'd test 'make tags' - and I noticed some additional problems. The series below fixes these issues. #1 - this is a general clean up, and is not really related to 'make tags' at all, #2 - this is your patch, but with the merge issue mentioned above fixed. #3 - this fixes some additional warnings I was seeing from 'make tags'. I'll give this some time for folk to comment before pushing. Thanks for your work on this, Andrew --- Andrew Burgess (2): gdb/Makefile.in: remove SOURCES variable gdb/Makefile.in: move ALLDEPFILES earlier in Makefile.in Reuben Thomas (1): gdb/Makefile.in: fix 'make tags' build target gdb/Makefile.in | 449 ++++++++++++++++++++++++------------------------ 1 file changed, 229 insertions(+), 220 deletions(-) -- 2.25.4